After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330346 - gnome-keyring support for storing DAAP passwords
gnome-keyring support for storing DAAP passwords
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: DAAP
HEAD
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-08 03:38 UTC by James "Doc" Livingston
Modified: 2006-07-31 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (9.39 KB, patch)
2006-05-30 08:52 UTC, James "Doc" Livingston 		none Details | Review
updated patch (9.39 KB, patch)
2006-06-18 12:39 UTC, James "Doc" Livingston 		none Details | Review
updated patch (10.81 KB, patch)
2006-06-25 07:14 UTC, Jonathan Matthew 		committed Details | Review

Description James "Doc" Livingston 2006-02-08 03:38:46 UTC 
It would be nice to have gnome-keyring support, so that we could offer to store DAAP share passwords in the user's keyring.
Comment 1 William Jon McCann 2006-02-09 16:16:54 UTC 
Right, I suppose this could be used for both the local share password and remote share passwords.

http://cvs.gnome.org/viewcvs/gnome-keyring/keyring-intro.txt?view=markup
Comment 2 Alex Lancaster 2006-02-19 16:51:13 UTC 
*** Bug 331776 has been marked as a duplicate of this bug. ***
Comment 3 James "Doc" Livingston 2006-05-30 08:52:05 UTC 
Created attachment 66461 [details] [review]
patch

This patch replaces our custom password-dialog with GnomePasswordDialog, and adds (optional) support for gnome-keyring. Currently I'm using the "service name" as in the "host" field, because ip addresses will often vary on dhcp networks.
Comment 4 Jonathan Matthew 2006-05-30 09:03:52 UTC 
I haven't tried it, but:

+	if test "x$have_gnbome_keyring" = "xno" -a "x$with_gnome_keyring" = "xyes"; then
                        ^^^^^^
looks a bit wrong.
Comment 5 James "Doc" Livingston 2006-06-18 12:39:26 UTC 
Created attachment 67571 [details] [review]
updated patch

Minor update and fix the typo.
Comment 6 Jonathan Matthew 2006-06-25 07:14:55 UTC 
Created attachment 67962 [details] [review]
updated patch

makes the 'store for this session' option work.
Comment 7 Jonathan Matthew 2006-07-31 13:58:11 UTC 
committed.