After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329895 - remember dimensions of the sessions properties dialog
remember dimensions of the sessions properties dialog
Status: RESOLVED OBSOLETE
Product: gnome-session
Classification: Core
Component: gnome-session-properties
2.13.x
Other All
: Normal minor
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-04 15:08 UTC by Jean-François Fortin Tam
Modified: 2014-03-05 11:39 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
la la la (4.65 KB, patch)
2007-05-08 16:08 UTC, Allison Karlitskaya (desrt)
needs-work Details | Review

Description Jean-François Fortin Tam 2006-02-04 15:08:55 UTC
The sessions properties dialog should remember its size if a user specified one. I
am filing this bug report because each time I want to use
gnome-sessions-properties, I
have to size it up again, over and over. This is similar to bug #324097. Some
solutions were suggested there, please take a look.

Other information:
Comment 1 Tom Tromey 2006-10-15 17:50:18 UTC
Sounds reasonable to me.
We'll probably be replacing this application with something
more "nautilus-like" -- in which case having it mimic spatial-ness
is a requirement.
Comment 2 Allison Karlitskaya (desrt) 2007-05-08 16:08:55 UTC
Created attachment 87818 [details] [review]
la la la
Comment 3 Vincent Untz 2007-05-09 13:23:35 UTC
Some comments:

you'll want to remove
gtk_window_set_default_size (GTK_WINDOW (dlg), -1, font_size * 40);
(or keep it when the gconf keys aren't set)

+  static int last_width, last_height;
They should have an initial value, I guess.

Also, there's no gconf handler goodness! :-)
Comment 4 Allison Karlitskaya (desrt) 2007-05-09 20:57:03 UTC
(In reply to comment #3)
> Some comments:
> 
> you'll want to remove
> gtk_window_set_default_size (GTK_WINDOW (dlg), -1, font_size * 40);
> (or keep it when the gconf keys aren't set)
ok.

 
> +  static int last_width, last_height;
> They should have an initial value, I guess.
C standard says that these are zero for sure.
 
> Also, there's no gconf handler goodness! :-)
this is more likely to cause weird race condition bugs than to be actually useful :)

if it ok with you, i will update the patch to fix only the first issue

Comment 5 Matthias Clasen 2014-03-05 11:39:07 UTC
gnome-session-properties is no longer included in gnome-session.