After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329429 - build against xulrunner trunk (gecko 1.9)
build against xulrunner trunk (gecko 1.9)
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
git master
Other All
: Normal major
: ---
Assigned To: Yelp maintainers
Yelp maintainers
: 335526 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-02-01 06:11 UTC by Mitch
Modified: 2006-04-20 17:53 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
fix (15.80 KB, patch)
2006-04-19 19:39 UTC, Christian Persch
none Details | Review
the right fix (15.80 KB, patch)
2006-04-19 19:42 UTC, Christian Persch
committed Details | Review

Description Mitch 2006-02-01 06:11:03 UTC
Please describe the problem:
yelp no longer compiles with seamonkey cvs even with --with-gecko=xulrunner
configure option since libgtkmozembed no longer exists and neither does the
pkgconfig .pc files so the build fails miserably. It needs to now be linked
against libxul.so

Steps to reproduce:
1. Attempt to build yelp with seamonkey cvs

Actual results:
Link fails

Expected results:


Does this happen every time?
yes

Other information:
I have logged mozilla 'bug'
 https://bugzilla.mozilla.org/show_bug.cgi?id=325117
which removes the *-gtkmozembed.pc file 

Also there is a epiphany 'bug'
 http://bugzilla.gnome.org/show_bug.cgi?id=329196
since it's the oter app that uses the gecko embedding engine.
Comment 1 Christian Persch 2006-02-01 14:10:14 UTC
This is not an urgent problem, though, since a gecko 1.9 release is more than 1 year off.

We'll try to fix epiphany's gecko.m4 as soon as someone of us finds time to build a xulrunner build :)
Comment 2 Mitch 2006-02-01 20:06:29 UTC
That may be the case, but anyone building cvs seamonkey from uptodate sources - which includes bug fixes cannot now link anymore gman/yelp
Comment 3 Christian Persch 2006-02-01 23:04:18 UTC
More accurately, anyone building seamonkey will *never again* be able to build any gtkmozembed using application against it.
Comment 4 Mitch 2006-02-16 11:42:54 UTC
Guys, can we just use epiphany's configure.in changes and gecko.m4 from bug 329196 which is fixed and now building correctly with xulrunner. Then we can close this 'bug'.
Comment 5 Christian Persch 2006-02-16 12:44:42 UTC
It needs a code change too, m4 + configure is not enough.
Comment 6 Christian Persch 2006-03-22 15:28:37 UTC
*** Bug 335526 has been marked as a duplicate of this bug. ***
Comment 7 Christian Persch 2006-04-19 19:39:26 UTC
Created attachment 63897 [details] [review]
fix
Comment 8 Christian Persch 2006-04-19 19:42:21 UTC
Created attachment 63898 [details] [review]
the right fix
Comment 9 Diego González 2006-04-19 23:27:22 UTC
with this patch yelp compiles but it crashes on startup, on the other hand devhelp from CVS HEAD compiles and works with on crashes (i say this because i think both yelp and devhelp shared, at least once, the glue code to talk to gecko).

I know that this backtrace won't be that useful, but it is all i have.

0xb74359bb in EmbedPrivate::Realize () from /opt/mozilla/lib/libxul.so
(gdb) bt
  • #0 EmbedPrivate::Realize
    from /opt/mozilla/lib/libxul.so
  • #1 gtk_moz_embed_realize
    from /opt/mozilla/lib/libxul.so
  • #2 g_cclosure_marshal_VOID__VOID
    from /usr/lib/libgobject-2.0.so.0
  • #3 ??
  • #4 ??
  • #5 ??
  • #6 g_value_peek_pointer
    from /usr/lib/libgobject-2.0.so.0
  • #7 ??
  • #8 ??
  • #9 g_cclosure_new_swap
    from /usr/lib/libgobject-2.0.so.0
  • #10 ??
  • #11 gtk_moz_embed_destroy
    from /opt/mozilla/lib/libxul.so
  • #12 ??
  • #13 ??

Comment 10 Christian Persch 2006-04-19 23:33:00 UTC
Does it make any difference if you export LD_LIBRARY_PATH=/opt/mozilla/lib then run yelp?
Comment 11 Diego González 2006-04-19 23:38:18 UTC
none at all
Comment 12 Christian Persch 2006-04-20 12:47:54 UTC
It works here.

How do you compile xulrunner? Do you use make install?
Comment 13 Diego González 2006-04-20 13:52:52 UTC
actually i'm not suing xulrunner but firefox. Somebody maked my bug as a duplicate of this one. I compile firefox with make -f client build and then i copy the contents of the dist directory to  /opt/mozilla. firefox is compiled with the flag --prefix=/opt/mozilla though.
Comment 14 Christian Persch 2006-04-20 14:03:29 UTC
Oh ok then, you shouldn't do that. We only support "make -f client.mk install" installed builds. And firefox isn't really supported for gecko 1.9, only xulrunner.

DonS, smitten: ok to commit the patch?
Comment 15 Don Scorgie 2006-04-20 17:12:12 UTC
Patch looks good to me.

Is the m4 stuff a resync with epiphany?  If so, is there a way to keep it in sync a bit better? (Move it to gnome-common?)  Just thought I'd ask.
Comment 16 Christian Persch 2006-04-20 17:53:03 UTC
The m4 is just a re-sync with epiphany, yes. It's not generic enough for gnome-common yet, IMHO.

Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.