After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329345 - 'Save to disk' overwrites existing files without prompting
'Save to disk' overwrites existing files without prompting
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.6.x (obsolete)
Other All
: High critical
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks: 327508
 
 
Reported: 2006-01-31 12:56 UTC by Victor Osadci (Vic)
Modified: 2013-09-13 00:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Proposed patch (3.44 KB, patch)
2006-04-21 19:21 UTC, Srinivasa Ragavan 		committed Details | Review

Description Victor Osadci (Vic) 2006-01-31 12:56:48 UTC 
Please describe the problem:
The calendar 'Save to disk' overwrites existing files without prompting.

Steps to reproduce:
1. Right click a calendar in the rigth pane and 'Save to disk'
2. type a file name to save to
3. Save


Actual results:
If an identicaly named file exists, it is being silently replaced.

Expected results:
Warn and prompt to replace or cancel.

Does this happen every time?
Yes

Other information:
Comment 1 André Klapper 2006-01-31 20:01:54 UTC 
confirming.
since one can lose data, raising priority. i'm targetting this to 2.5.

also note that we are under UI freeze.

we should reuse the string
"A file by that name already exists.\n"
"Overwrite it?"
from #: ../e-util/e-dialog-utils.c, so at least we would not need to inform the translators.
Comment 2 André Klapper 2006-01-31 20:05:12 UTC 
shortening the summary a bit so it can be read easier in the search results
Comment 3 Srinivasa Ragavan 2006-02-04 09:38:48 UTC 
It was fixed already.
Comment 4 Victor Osadci (Vic) 2006-04-07 21:21:14 UTC 
Reopening as this has not been fixed. I can still reproduce the bug in 2.6 .
Comment 5 Srinivasa Ragavan 2006-04-17 04:02:42 UTC 
Victor, do you see a confirmation dialog atleast? I see it in calendar. May be im looking at the wrong place.
Comment 6 Victor Osadci (Vic) 2006-04-17 08:35:30 UTC 
Sri, maybe the initial description wasn't detailed enough - I'll try again.
Evo is 2.6.1 .

1. Open the Calendar component (Ctrl+3)
2. Choose "Save to disk" from the context menu of a calendar in the left pane. By default I see one named "Personal".
3. Repeat step 2. No confirmation is given.

P.S. I just noticed the difference from my original report - s/right/left/
Comment 7 Srinivasa Ragavan 2006-04-17 09:12:58 UTC 
right. Now I get it. Till now i was trying with the attachment of an event.
Comment 8 Srinivasa Ragavan 2006-04-21 19:21:44 UTC 
Created attachment 64068 [details] [review]
Proposed patch
Comment 9 Srinivasa Ragavan 2006-04-21 19:22:27 UTC 
If you save with other formats it will ask for overwrite. It doesnt only if u save as ical. This fixes it.
Comment 10 Srinivasa Ragavan 2006-04-21 19:23:55 UTC 
Fixed to HEAD.
Comment 11 Harish Krishnaswamy 2006-04-22 05:48:39 UTC 
Why not to the 2.6.x branch ?
Comment 12 André Klapper 2006-07-03 00:56:28 UTC 
http://cvs.gnome.org/viewcvs/evolution/plugins/save-calendar/ical-format.c?r1=1.4&r2=1.5
reopening. srini: should this also go into the stable branch?
Comment 13 Srinivasa Ragavan 2006-07-03 04:31:07 UTC 
Fixed to STABLE also.