Bug 329329 – RB spins when all tracks are unplayable and using "endless" play order

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 329329 - RB spins when all tracks are unplayable and using "endless" play order


Summary:	RB spins when all tracks are unplayable and using "endless" play order


Status:	RESOLVED OBSOLETE

Product:	rhythmbox
Classification:	Other
Component:	playback
Version:	HEAD
Hardware:	Other Linux

Importance:	Normal major
Target Milestone:	---
Assigned To:	RhythmBox Maintainers
QA Contact:	RhythmBox Maintainers

URL:
Whiteboard:

Duplicates:	349922 (view as bug list)
Depends on:
Blocks:

Reported:	2006-01-31 10:37 UTC by Bastien Nocera
Modified:	2018-05-24 11:12 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
patch (1.42 KB, patch) 2006-01-31 11:28 UTC, Jonathan Matthew	committed	Details \| Review

Description Bastien Nocera 2006-01-31 10:37:43 UTC

gstreamer-0.10.2-1
rhythmbox-0.9.2.cvs20060123-1

1. Load up loads of MP3s in the library (I did that in RB s/ gst 0.8)
2. Exit RB
3. remove the MP3 plugin
4. Start up RB
5. Try to play songs
6. RB will mark all the entries as not playable in turns
7. Press the play/pause button
8. RB will be changing the window title between "Song name" and "Song name (paused)" all the time

+ Trace 65780

#0 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#1 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#2 g_object_class_override_property
from /usr/lib/libgobject-2.0.so.0
#3 g_enum_register_static
from /usr/lib/libgobject-2.0.so.0
#4 g_object_notify
from /usr/lib/libgobject-2.0.so.0
#5 gtk_widget_add_events
from /usr/lib/libgtk-x11-2.0.so.0
#6 gtk_drag_source_set
from /usr/lib/libgtk-x11-2.0.so.0
#7 gnome_href_set_url
from /usr/lib/libgnomeui-2.so.0
#8 rb_song_display_box_sync
#9 rb_header_sync
#10 rb_shell_player_sync_buttons
#11 rb_shell_player_playpause
#12 rb_shell_player_playpause
#13 g_cclosure_marshal_VOID__VOID
from /usr/lib/libgobject-2.0.so.0
#14 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#15 g_signal_override_class_closure
from /usr/lib/libgobject-2.0.so.0
#16 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#17 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#18 gtk_accessible_connect_widget_destroyed
from /usr/lib/libgtk-x11-2.0.so.0
#19 gtk_action_activate
from /usr/lib/libgtk-x11-2.0.so.0
#20 g_cclosure_marshal_VOID__VOID
from /usr/lib/libgobject-2.0.so.0
#21 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#22 g_signal_override_class_closure
from /usr/lib/libgobject-2.0.so.0
#23 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#24 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#25 gtk_tool_button_new_from_stock
from /usr/lib/libgtk-x11-2.0.so.0
#26 g_cclosure_marshal_VOID__VOID
from /usr/lib/libgobject-2.0.so.0
#27 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#28 g_signal_override_class_closure
from /usr/lib/libgobject-2.0.so.0
#29 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#30 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#31 gtk_button_clicked
from /usr/lib/libgtk-x11-2.0.so.0
#32 gtk_toggle_action_new
from /usr/lib/libgtk-x11-2.0.so.0
#33 g_cclosure_marshal_VOID__VOID
from /usr/lib/libgobject-2.0.so.0
#34 g_value_set_static_boxed
from /usr/lib/libgobject-2.0.so.0
#35 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#36 g_signal_override_class_closure
from /usr/lib/libgobject-2.0.so.0
#37 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#38 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#39 gtk_button_released
from /usr/lib/libgtk-x11-2.0.so.0
#40 gtk_button_released
from /usr/lib/libgtk-x11-2.0.so.0
#41 gtk_marshal_BOOLEAN__VOID
from /usr/lib/libgtk-x11-2.0.so.0
#42 g_value_set_static_boxed
from /usr/lib/libgobject-2.0.so.0
#43 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#44 g_signal_override_class_closure
from /usr/lib/libgobject-2.0.so.0
#45 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#46 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#47 gtk_widget_get_default_style
from /usr/lib/libgtk-x11-2.0.so.0
#48 gtk_propagate_event
from /usr/lib/libgtk-x11-2.0.so.0
#49 gtk_main_do_event
from /usr/lib/libgtk-x11-2.0.so.0
#50 gdk_add_client_message_filter
from /usr/lib/libgdk-x11-2.0.so.0
#51 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#52 g_main_context_check
from /usr/lib/libglib-2.0.so.0
#53 g_main_loop_run
from /usr/lib/libglib-2.0.so.0
#54 bonobo_main
from /usr/lib/libbonobo-2.so.0
#55 main

Comment 1 Jonathan Matthew 2006-01-31 11:28:05 UTC

Created attachment 58458 [details] [review]
patch

I don't entirely understand why this fixes it.  It also fixes the first click of the 'play' button causing it to pause rather than play.

Comment 2 James "Doc" Livingston 2006-01-31 12:36:11 UTC

Looks good to me.

A side though: if you have only non-playable tracks, and are using one of the endless play orders (linear-loop, random-*) will it spin switching tracks?

Comment 3 James "Doc" Livingston 2006-01-31 15:42:21 UTC

I've committed the patch to cvs.

Comment 4 James "Doc" Livingston 2006-06-07 05:31:12 UTC

Retitling to reflect remaining issue.

Comment 5 James "Doc" Livingston 2006-07-20 03:09:12 UTC

*** Bug 347966 has been marked as a duplicate of this bug. ***

Comment 6 James "Doc" Livingston 2006-07-20 03:10:35 UTC

Perhaps a solution would be to stop if we try to start too many tracks in too short a time, say 5 in 10 seconds or something.

Comment 7 James "Doc" Livingston 2006-08-04 12:45:46 UTC

*** Bug 349922 has been marked as a duplicate of this bug. ***

Comment 8 Steve Fosdick 2007-01-12 14:39:07 UTC

Or remember the first non-playable track seen in a playlist and if we end up back at the same song again without sucessfully playing any other songs then stop.

Comment 9 GNOME Infrastructure Team 2018-05-24 11:12:08 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/131.