GNOME Bugzilla – Bug 329246
Patch for adding a fullscreen preview.
Last modified: 2007-07-01 20:58:38 UTC
This patch adds a fullscreen preview of the currently selected screensaver.
Created attachment 58409 [details] [review] The callback implementations for a fullscreen preview
Created attachment 58410 [details] [review] The GUI modifications for a fullscreen preview
Could you evaluate this patch for inclusion? Many users are waiting for it in Ubuntu (and hoping it will come in time to Dapper). The developer of this patch has some other patches regarding memory leaks and the like he would like to contribute, but is awaiting response on this first.
*** Bug 334833 has been marked as a duplicate of this bug. ***
By the way, don't believe everything you read on web forums. The primary reason this patch wasn't considered is because it came in after feature and UI freezes. The secondary reason is that I've been busy doing other things. Paul, if the reporter has other patches he should file other bugs. Memory leaks aren't subject to the same code freezes. If he is withholding them on purpose that is just irresponsible.
Created attachment 62413 [details] [review] patch That looked pretty good. I've modified it a bit to: * reuse the same job * move the preview button * simplify the warning message in fullscreen mode * use enter/leave fullscreen icons for buttons * make leave fullscreen button fit against screen edge (Fitt's law)
Created attachment 62417 [details] [review] updated patch Fixed a few things. Added navigation and name in fullscreen preview.
I applied your new patch and it looks great. I really like the navigation buttons.
Committed to HEAD. 2006-04-10 William Jon McCann <mccann@jhu.edu> * src/gs-job.c (gs_job_set_widget): Restart job when target widget is changed. * data/gnome-screensaver-preferences.glade: * src/gnome-screensaver-preferences.c: Add a fullscreen preview. Also try to constrain theme list so that at least a few are visible at once. Based on patch from Emmanuel Rodriguez <emmanuel.rodriquez@gmail.com> Fixes #329246
*** Bug 347427 has been marked as a duplicate of this bug. ***
*** Bug 348304 has been marked as a duplicate of this bug. ***
Although this bug has been closed as fixed, can (or should) the severity be changed to "Enhancement"? While working from Debian Etch, I noticed that gnome-screensaver did not have a preview button. While searching for Enhancement requests (before creating my own) I only discovered other bugs closed as duplicates to this one. Just my 2 cents worth. Keep up the great work.