After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329246 - Patch for adding a fullscreen preview.
Patch for adding a fullscreen preview.
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: dialog
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
: 334833 347427 348304 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-30 18:17 UTC by Emmanuel Rodriguez
Modified: 2007-07-01 20:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The callback implementations for a fullscreen preview (5.82 KB, patch)
2006-01-30 18:19 UTC, Emmanuel Rodriguez
none Details | Review
The GUI modifications for a fullscreen preview (11.94 KB, patch)
2006-01-30 18:20 UTC, Emmanuel Rodriguez
none Details | Review
patch (16.31 KB, patch)
2006-03-30 19:09 UTC, William Jon McCann
none Details | Review
updated patch (23.19 KB, patch)
2006-03-30 20:18 UTC, William Jon McCann
committed Details | Review

Description Emmanuel Rodriguez 2006-01-30 18:17:25 UTC
This patch adds a fullscreen preview of the currently selected screensaver.
Comment 1 Emmanuel Rodriguez 2006-01-30 18:19:36 UTC
Created attachment 58409 [details] [review]
The callback implementations for a fullscreen preview
Comment 2 Emmanuel Rodriguez 2006-01-30 18:20:34 UTC
Created attachment 58410 [details] [review]
The GUI modifications for a fullscreen preview
Comment 3 Paul Eipper 2006-03-17 02:16:04 UTC
Could you evaluate this patch for inclusion?
Many users are waiting for it in Ubuntu (and hoping it will come in time to Dapper).

The developer of this patch has some other patches regarding memory leaks and the like he would like to contribute, but is awaiting response on this first.
Comment 4 William Jon McCann 2006-03-17 03:06:48 UTC
*** Bug 334833 has been marked as a duplicate of this bug. ***
Comment 5 William Jon McCann 2006-03-17 03:10:41 UTC
By the way, don't believe everything you read on web forums.  The primary reason this patch wasn't considered is because it came in after feature and UI freezes.  The secondary reason is that I've been busy doing other things.

Paul, if the reporter has other patches he should file other bugs.  Memory leaks aren't subject to the same code freezes.  If he is withholding them on purpose that is just irresponsible.
Comment 6 William Jon McCann 2006-03-30 19:09:42 UTC
Created attachment 62413 [details] [review]
patch

That looked pretty good.  I've modified it a bit to:

 * reuse the same job
 * move the preview button
 * simplify the warning message in fullscreen mode
 * use enter/leave fullscreen icons for buttons
 * make leave fullscreen button fit against screen edge (Fitt's law)
Comment 7 William Jon McCann 2006-03-30 20:18:53 UTC
Created attachment 62417 [details] [review]
updated patch

Fixed a few things.  Added navigation and name in fullscreen preview.
Comment 8 Emmanuel Rodriguez 2006-03-31 21:46:14 UTC
I applied your new patch and it looks great.
I really like the navigation buttons.
Comment 9 William Jon McCann 2006-04-10 17:35:34 UTC
Committed to HEAD.

2006-04-10  William Jon McCann  <mccann@jhu.edu>

	* src/gs-job.c (gs_job_set_widget): Restart job when
	target widget is changed.

	* data/gnome-screensaver-preferences.glade: 
	* src/gnome-screensaver-preferences.c:
	Add a fullscreen preview.  Also try to constrain theme list
	so that at least a few are visible at once.

	Based on patch from Emmanuel Rodriguez <emmanuel.rodriquez@gmail.com>
	Fixes #329246
Comment 10 William Jon McCann 2006-07-13 16:48:02 UTC
*** Bug 347427 has been marked as a duplicate of this bug. ***
Comment 11 William Jon McCann 2006-07-22 06:03:57 UTC
*** Bug 348304 has been marked as a duplicate of this bug. ***
Comment 12 Aaron Ahlemeyer 2007-07-01 20:58:38 UTC
Although this bug has been closed as fixed, can (or should) the severity be changed to "Enhancement"?

While working from Debian Etch, I noticed that gnome-screensaver did not have a preview button.  While searching for Enhancement requests (before creating my own) I only discovered other bugs closed as duplicates to this one.

Just my 2 cents worth.  Keep up the great work.