GNOME Bugzilla – Bug 328912
misc fixes
Last modified: 2006-02-12 00:07:52 UTC
Attached patch - make gucharmap use goption argument parsing (no more popt!) - updates configure accordingly, and also modernises it a bit - removes gucharmap-intl.[ch], replaced by simple <glib/gi18n.h> includes, and fixes the strange gettext initialisation - fixes make dist when you didn't configure with gnome enabled
Created attachment 58238 [details] [review] the patch
Impressive! About the gettext stuff, I was making this change myself, but change mind. gucharmap provides a library too. Does simply using gettext work if there are translated strings in the library?
Hmmm... I didn't take the library into account, that complicates the gettext thing. Is there a central entry point into the library that all users will have to call first, "gucharmap_init()" ?
No, note one that I can see. It's just a widget you use...
Now that you've got these changes for gucharmap, can you take a look at dasher too, if you have some time? It can use the GOption transition... Thanks.
All public headers are for widgets, except gucharmap-unicode-info... we could add a ensure_gettext_inited() in the class inits, but that won't work for unicode-info.... Maybe just take the other bits and leave out all the gettext changes?
There are only two functions in the unicode-info stuff that use translations... We can ensure there too... But that makes me wonder, is it worth it? Guess not. I'll leave out the gettext change and commit the rest.
I'm also changing the name from "GNOME Unicode Character Map" to simply "GNOME Character Map". Behnam, where are the other places we need to make this change to comply with the HIG?
Humm, I'm getting a bit confused about which changes in main.c should remain and which should go. Can you attach an updated patch please?
I'm not pro in libtools, but please don't use "Unicode" in the application description. Just use "GNOME Character Map". Also use "Gucharmap" in title-case for the application name. BTW, Behdad: I get a warning message for the second argument of that function in gucharmap-intl.h.
The patch merge to the patch to "Bug 326272 – Help/About dialog isn't HIG compliant": Attachment #58702 [details]
No, do not merge patches.
Created attachment 59155 [details] [review] updated patch ensure gettext initialisation in the library where used.
Thanks a lot. 2006-02-11 Behdad Esfahbod <behdad@gnome.org> Bug 328912 – misc fixes Patch from Christian Persch * autogen.sh, configure.ac, Makefile.am: Modernize the build system. * gucharmap/*.c: gucharmap_intl_ensure_initialized () in every library entry point. Use gi18n-lib.h instead of custom gettext. * gucharmap/main.c: Use GOption instead of popt.