GNOME Bugzilla – Bug 328816
Recent CVS change causes DAAP to not connect
Last modified: 2006-01-27 10:12:52 UTC
Please describe the problem: I was attempting to connect to an iTunes server with a password that I have been using reliably for several months now. Now it appears in the sidepane, but when I click it, nothing appears, no password prompt, no error message. I thought it was something to do with the mDNSResponder so I restarted that, but still the same problem. I checked and restarted the iTunes server, made sure that the port was open, all seems fine. If I revert this this change: 2006-01-25 James Livingston <jrl@ids.org.au> patch by: Christope Fergeau <teuf@gnome.org> * daapsharing/rb-daap-connection.c: (g_zalloc_wrapper), (http_response_handler): fix a potential buffer overflow issue. then all is well and I can connect. Steps to reproduce: 1. update to latest CVS, compile 2. run, attempt to connect 3. revert this patch: http://cvs.gnome.org/viewcvs/rhythmbox/daapsharing/rb-daap-connection.c?r1=1.13&r2=1.14 4. recompile 5. attempt to connect Actual results: First time it doesn't connect: [0x8ad3128] [rb_daap_connection_constructor] rb-daap-connection.c:1441 (01:16:10): Creating new DAAP connection to 192.168.0.4:3689 [0x8ad3128] [rb_daap_connection_do_something] rb-daap-connection.c:1540 (01:16:10): Getting DAAP server info [0x8ad3128] [http_get] rb-daap-connection.c:927 (01:16:10): Queued message for http://192.168.0.4:3689//server-info [0x8ad3128] [rb_shell_clipboard_set_property] rb-shell-clipboard.c:274 (01:16:10): selected source 0x8de6678 [0x8ad3128] [rb_shell_clipboard_sync] rb-shell-clipboard.c:387 (01:16:10): syncing clipboard [0x8ad3128] [rb_shell_player_set_property] rb-shell-player.c:650 (01:16:10): selected source 0x8de6678 [0x8ad3128] [rb_shell_player_sync_with_selected_source] rb-shell-player.c:2128 (01:16:10): syncing with selected source: 0x8de6678 [0x8ad3128] [rb_shell_player_sync_buttons] rb-shell-player.c:1907 (01:16:10): syncing with source 0x8de6678 [0x8ad3128] [rb_source_header_set_property] rb-source-header.c:232 (01:16:10): selected source 0x8de6678 [0x8ad3128] [rb_statusbar_set_property] rb-statusbar.c:287 (01:16:10): selected source 0x8de6678 [0x8ad3128] [http_response_handler] rb-daap-connection.c:883 (01:16:10): Error getting http://192.168.0.4:3689/: 200, OK But no info on getting tracks, no feedback Second time it connects, get a similar traceback, although I start seeing tracks appear after the 200, OK message. Expected results: Should connect Does this happen every time? Only in version 1.14 of rb-daap-connection.c. Other information:
Fixed in CVS now with this change: http://cvs.gnome.org/viewcvs/rhythmbox/daapsharing/rb-daap-connection.c?r1=1.14&r2=1.15