After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328710 - Can't press Remove in Cookie view repeatedly
Can't press Remove in Cookie view repeatedly
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Passwords, Cookies, & Certificates
1.9.x
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 347365 (view as bug list)
Depends on: 56070
Blocks:
 
 
Reported: 2006-01-26 11:29 UTC by spark
Modified: 2008-08-01 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
workaround (800 bytes, patch)
2007-12-13 11:39 UTC, Cosimo Cecchi
rejected Details | Review

Description spark 2006-01-26 11:29:05 UTC
The remove button in PDM is behaving a bit strangely -- if you click Remove to remove one cookie and then click it again without moving the mouse out of the button area (to try to remove the next cookie) nothing happens (although the button does get focused). It works fine if you move your mouse outside the confines of the button and then click it.

Also if you focus the Remove button and press spacebar to remove a cookie, the focus then moves away somewhere -- i would expect the focus to remain on the remove button so further cookies can be removed.

This might apply to the passwords bit too.
Comment 1 Christian Persch 2006-02-15 21:28:38 UTC
It's the infamouse gtk+ bug 56070, but maybe we can work around it.
Comment 2 Jean-François Rameau 2006-07-13 08:32:09 UTC
*** Bug 347365 has been marked as a duplicate of this bug. ***
Comment 3 Cosimo Cecchi 2007-12-13 11:39:41 UTC
Created attachment 100877 [details] [review]
workaround

Attached patch is a workaround for this bug, as for http://bugzilla.gnome.org/show_bug.cgi?id=56070#c90 and it works fine.
It also restores the right focus to the button after having been activated, so that user can delete by repeatedly press enter or spacebar.
Comment 4 Christian Persch 2007-12-22 23:08:05 UTC
I'm sorry, but we should get the gtk bug fixed, not do bogus workarounds.
Comment 5 Reinout van Schouwen 2008-08-01 10:45:07 UTC
Now that bug 56070 is fixed, is there anything left to do here?
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2008-08-01 11:03:27 UTC
If you press space bar when the button has focus, the focus is lost, so you can't keep space-bar'ing. Can we use:

+	/* Restore the focus to the button */
+	gtk_widget_grab_focus (button);

from Cosimo's patch?
Comment 7 Christian Persch 2008-08-01 11:18:35 UTC
Yes.
Comment 8 Diego Escalante Urrelo (not reading bugmail) 2008-08-01 12:13:09 UTC
Mr García López, please commit the grab_focus fix!
Comment 9 Cosimo Cecchi 2008-08-01 13:11:23 UTC
Done. Closing as FIXED, as it seems there's nothing else we can do here.

------------------------------------------------------------------------
r8372 | cosimoc | 2008-08-01 15:10:07 +0200 (Fri, 01 Aug 2008) | 2 lines

Bug #328710. Re-focus the "Remove" button after the selection has been deleted.
Comment 10 Diego Escalante Urrelo (not reading bugmail) 2008-08-01 13:16:21 UTC
And to 2-24!.
Comment 11 Cosimo Cecchi 2008-08-01 14:07:24 UTC
Done.