After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328228 - upon startup gpm launches hibernate
upon startup gpm launches hibernate
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-manager
SVN TRUNK
Other Linux
: Normal blocker
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on: 326743
Blocks:
 
 
Reported: 2006-01-23 00:55 UTC by Diego González
Modified: 2006-02-06 10:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test patch (969 bytes, patch)
2006-01-25 20:07 UTC, Richard Hughes 		none Details | Review

Description Diego González 2006-01-23 00:55:12 UTC 
with the latest changes as soon as i login into gnome and gnome-power-manager is loaded it triggers hibernation.
Comment 1 Richard Hughes 2006-01-23 01:14:03 UTC 
Diego, can you try the patch from:

http://bugzilla.gnome.org/attachment.cgi?id=57880&action=view

specifically the change in src/gpm-manager.c:

-	/* less than critical, do action */
-	if (percentage < critical_threshold) {
+	/* Just after unplugging remaining_time can be 0 because it could
+         * not be determined yet 
+         */
+	if (primary && discharging && remaining_time != 0 && 
+	    remaining_time < BATTERY_CRITICAL_REMAINING_TIME) {

Thanks,

Richard.
Comment 2 Diego González 2006-01-23 01:45:12 UTC 
it seems to work.
Comment 3 Jaap A. Haitsma 2006-01-23 10:10:58 UTC 
I think Diego was seeing the bug I told you about. We're hibernating whenever any of the battery powered devices is critical
Comment 4 Diego González 2006-01-23 10:50:51 UTC 
it might be, but my laptop, when that happend did have the battery in and was running on the AC power cable.

I have also observed that since some time ago GPM doesn't hibernate the computer after the time specified in the gpm-preferences expires. Don't know if they are related in any way, though.
Comment 5 Richard Hughes 2006-01-23 12:22:48 UTC 
>I have also observed that since some time ago GPM doesn't hibernate the
>computer after the time specified in the gpm-preferences expires. Don't know if
>they are related in any way, though.

Is this with a really recent gnome-screensaver? I'm having issues with the signals from g-s, I think I need to have a closer look.
It works okay for Jon, so this might just be a config issue -- I'll have a play today.

Richard.
Comment 6 Diego González 2006-01-23 12:44:57 UTC 
yeap, gnome-screensaver from CVS
Comment 7 Richard Hughes 2006-01-24 20:17:07 UTC 
Diego, does the current g-p-m cvs fix the issue of hibernation on startup? If so, can you please close the bug, many thanks.
Comment 8 Diego González 2006-01-25 00:22:22 UTC 
it is still there. Sorry.
Comment 9 Richard Hughes 2006-01-25 00:28:47 UTC 
Okay, I've committed another fix. Could you wait for anon-cvs to sync please, and then try again.

You'll know it has synced when:

2006-01-25  Richard Hughes  <richard@hughsie.com>
	* src/gpm-manager.c (power_battery_power_changed_cb): Only do action
	when discharging, trying to fix bug (#328228)

is the top entry in the ChangeLog.

Many thanks,

Richard.
Comment 10 Richard Hughes 2006-01-25 20:07:13 UTC 
Created attachment 58124 [details] [review]
test patch

Also, if that doesn't work, could you try this patch please.
Comment 11 Richard Hughes 2006-02-06 00:11:17 UTC 
Diego, has this been fixed in CVS?
Comment 12 Diego González 2006-02-06 10:04:55 UTC 
sorry. Yes it is fixed