GNOME Bugzilla – Bug 328146
missing&conflicting mnemonics in mail composer
Last modified: 2008-04-08 01:27:29 UTC
"File | Send" misses a mnemonic. "Edit | Select _All" and "Edit | Find _Again" and "Edit | Ch_aracter Encoding" use the same mnemonic. "Edit | _Redo" and "Edit | _Replace" use the same mnemonic. "Insert | Send Options" misses a mnemonic. "Format | _Page" and "Format | _Paragraph" use the same mnemonic. "Format | _Increase Indent" should be changed as the mnemonic of the narrow "I" letter cannot be easily recognized. every item in the "Security" menu misses a mnemonic.
Product GtkHTML, confirming.
*** Bug 327689 has been marked as a duplicate of this bug. ***
Format / _Increase Indent is fine IMHO. "I" is the only mnemonic that really makes sense here. Being hard to spot is, well, an issue of your chosen font. ;)
Created attachment 58153 [details] [review] Added some missing mnemonics and Changed some similar mnemonics this is my patch for the bug. i have made changes in evolution and in gtkhtml modules so i have combined the two module codes and the 2 module ChangeLog files into a single patch.
gtkhtml is string frozen now. sorry, punting this to next cycle. ryan, though it can be discouraging to have a patch not applied, please don't hesitate to submit further patches if you like to. your efforts are appreciated, and this one here looks really good. this time we were just to slow. :-(
targetting.
some minor issues need to be corrected. i'm going to enhance ryan's patch. proposals: Send -> _Send _Redo -> Re_do let's not use "Se_lect All" - L is already used for "Current _Languages" Find _Again -> Find agai_n (let's not use a "g" as the mnemonic will not be displayed then) Ch_aracter Encoding -> Character Enc_oding Send Options -> _Send Options (this is probably in plugins/groupwise-features/org-gnome-compose-send-options.xml and was not covered by ryan's patch) _Paragraph -> Pa_ragraph every item in the "Security" menu misses a mnemonic.
Created attachment 68782 [details] [review] enhanced and corrected patch okay, let's keep "Ch_aracter encoding" to keep consistency with the mail window menu. so let's change Select _All -> S_elect All
"Select _All" does not get fixed by this, and guenther does not like "Re_do".
Select _All is also used in the other composers. garr... this is a mess. perhaps i should at least submit a partial fix.
Removing the milestone we've missed anyway
Bumping version to a stable release.
Oof, some of these issues are still in the new Evolution 2.24 composer. The above patches are obsolete now because the composer code is entirely different. I'll make it a point to clean this up before 2.23.1 ships. Adding this to my "new composer" tracker (bug #522153).
I think I have this cleaned up now. Here's what I fixed: File Menu --------- No issues. Edit Menu --------- _Copy vs _Current Languages -> Current _Languages Select _All vs Ch_aracter Encoding -> Character _Encoding View Menu --------- No issues. Insert Menu ----------- _Emoticon vs R_equest Read Receipt -> Re_quest Read Receipt Format Menu ----------- HTML Mode -> HTML _Mode Header 5 -> Header _5 Header 6 -> Header _6 _Paragraph vs _Page -> Pa_ge Security Menu ------------- No issues. Fixed in GtkHTML revision 8816 and Evolution revision 35339. Feel free to reopen this if you spot anything I missed.