After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328129 - [PATCH] Thumbnailes which require scaling crash Nautilus
[PATCH] Thumbnailes which require scaling crash Nautilus
Status: RESOLVED DUPLICATE of bug 327323
Product: libgnomeui
Classification: Deprecated
Component: general
2.13.x
Other All
: Normal critical
: future
Assigned To: libgnomeui maintainers
libgnomeui maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-22 04:17 UTC by Joe Marcus Clarke
Modified: 2006-02-07 13:37 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Fix thumbnailing crash (1.02 KB, patch)
2006-01-22 04:18 UTC, Joe Marcus Clarke 		reviewed Details | Review

Description Joe Marcus Clarke 2006-01-22 04:17:10 UTC 
Steps to reproduce:
1. Open a directory that contains thumbnailable files in Nautilus
2. Witness crash if said files requiring scaling
3. 


Stack trace:

+ Trace 65480

  • #0 IA__g_logv
  • #1 IA__g_log
    at gmessages.c line 517
  • #2 IA__g_return_if_fail_warning
    at gmessages.c line 532
  • #3 IA__g_convert
  • #4 real_save_png
    at io-png.c line 863
  • #5 gdk_pixbuf__png_image_save
    at io-png.c line 981
  • #6 IA__gdk_pixbuf_savev
    at gdk-pixbuf-io.c line 1407
  • #7 IA__gdk_pixbuf_save
    at gdk-pixbuf-io.c line 1634
  • #8 gnome_thumbnail_factory_save_thumbnail
    at gnome-thumbnail.c line 1175
  • #9 thumbnail_thread_start
    at nautilus-thumbnails.c line 592
  • #10 thread_start
    at /usr/src/lib/libpthread/thread/thr_create.c line 341
  • #11 _ctx_start
    at /usr/src/lib/libc/i386/gen/_ctx_start.S line 43 


Other information:
The problem is that when scaling is performed, the object properties for width
ahd height get blown away.  Therefore, when the PNG pixbuf driver tries to
reference them, it gets a NULL value, and aborts.  The attached patch makes sure
the object properties are added after any required scaling is performed.
Comment 1 Joe Marcus Clarke 2006-01-22 04:18:03 UTC 
Created attachment 57834 [details] [review]
Fix thumbnailing crash
Comment 2 Christian Persch 2006-01-22 10:44:28 UTC 
See also bug 327323.
Comment 3 Christian Kirbach 2006-01-23 00:36:43 UTC 
thanks for a patch but it does not work for chpe nor me
Comment 4 Kjartan Maraas 2006-02-07 13:33:39 UTC 
Isn't this a duplicate of bug 327323?
Comment 5 Kjartan Maraas 2006-02-07 13:36:01 UTC 
Yep it is.
Comment 6 Kjartan Maraas 2006-02-07 13:37:42 UTC 

*** This bug has been marked as a duplicate of 327323 ***