After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328082 - visual appearance of gtkassistant/HIG
visual appearance of gtkassistant/HIG
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-01-21 21:29 UTC by Christian Persch
Modified: 2006-01-30 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.89 KB, patch)
2006-01-30 12:20 UTC, Carlos Garnacho 		none Details | Review
sample screenshot (15.27 KB, image/png)
2006-01-30 12:22 UTC, Carlos Garnacho 		  Details

Description Christian Persch 2006-01-21 21:29:39 UTC 
IMHO at least the border aorund the action area should probably follow that of gtkdialogs, i.e. be 12px between border and the buttons. (BTW, why is this not using a GtkHButtonBox for the action area?)

Maybe the whole assistant should have a 12px border; see bug-buddy HEAD for how that would look (that's just glade, not using gtkassistant yet).
Comment 1 Matthias Clasen 2006-01-22 05:52:02 UTC 
Sounds right. Do you have a patch ?
Comment 2 Matthias Clasen 2006-01-23 19:13:06 UTC 
I tried to make the button spacing a bit more HIG compliant. 
Patches for further fixes (and for the whole assistant border)
would be appreciated.
Comment 3 Carlos Garnacho 2006-01-30 12:20:35 UTC 
Created attachment 58388 [details] [review]
patch

It adds a 12px border to the window, and a 12px separation between the action area and the colored box.
Comment 4 Carlos Garnacho 2006-01-30 12:22:30 UTC 
Created attachment 58389 [details]
sample screenshot
Comment 5 Matthias Clasen 2006-01-30 15:52:44 UTC 
2006-01-30  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkassistant.c: More generous spacing. (#328082,
	Christian Persch, patch by Carlos Garnacho)