After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328018 - gtkmessagedialogs aren't HIG compliant
gtkmessagedialogs aren't HIG compliant
Status: RESOLVED DUPLICATE of bug 163850
Product: gtk+
Classification: Platform
Component: Widget: Other
2.8.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-01-21 17:44 UTC by Crispin Flowerday (not receiving bugmail)
Modified: 2006-02-02 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Testcase (847 bytes, text/plain)
2006-01-21 17:45 UTC, Crispin Flowerday (not receiving bugmail) 		  Details
Screenshot (10.47 KB, image/png)
2006-01-21 17:46 UTC, Crispin Flowerday (not receiving bugmail) 		  Details
proposed fix (3.92 KB, patch)
2006-01-21 20:38 UTC, Christian Persch 		none Details | Review

Description Crispin Flowerday (not receiving bugmail) 2006-01-21 17:44:54 UTC 
The HIG says that dialogs should have a border of 12 pixels around the outside of them, however the gtkmessagedialog doesn't (when using the HIG API). See the testcase and screenshot.
Comment 1 Crispin Flowerday (not receiving bugmail) 2006-01-21 17:45:16 UTC 
Created attachment 57803 [details]
Testcase
Comment 2 Crispin Flowerday (not receiving bugmail) 2006-01-21 17:46:28 UTC 
Created attachment 57804 [details]
Screenshot

there should be 12 pixels between the button and the border, however there is just 6
Comment 3 Christian Persch 2006-01-21 20:38:30 UTC 
Created attachment 57820 [details] [review]
proposed fix

This makes the spacings HIG compliant.
I'm not sure what to do with the 'message-border' style property, though; it doesn't make sense to follow that when setting up everything HIGgy, so it's just ignored with the patch.
Comment 4 Christian Persch 2006-02-02 16:03:04 UTC 

*** This bug has been marked as a duplicate of 163850 ***