GNOME Bugzilla – Bug 327874
Slightly better URL parsing in text msgs
Last modified: 2006-07-31 15:30:27 UTC
Consider the portion of mail: <http://mysystem/MSDOS/'SHARED.PZ00.PROD.SUPERBATCH.ZIPLIB(Z00055R)'> The URL is actually: http://mysystem/MSDOS/'SHARED.PZ00.PROD.SUPERBATCH.ZIPLIB(Z00055R)' But Evolution only highlights: http://mysystem/MSDOS/'SHARED.PZ00.PROD.SUPERBATCH.ZIPLIB(Z00055R From RFC 1738: Thus, only alphanumerics, the special characters "$-_.+!*'(),", and reserved characters used for their reserved purposes may be used unencoded within a URL. The attached patch will rewind only if the character doesn't have a matching one in the URL.
Created attachment 57736 [details] [review] gtkhtml3-try-match-url-garbage-2.patch
Wasn't tested, and the code changes should actually be in src/htmltext.c in the regexps in HTMLMagicInsertMatch.
Created attachment 60326 [details] [review] gtkhtml3-try-match-url-garbage-3.patch ' is an allowed character in a URL, so let's allow it in the regexp
Patch was verified for e-mail creation, but it's not enough for e-mail reading.
Bastien : are you working on this patch for e-mail reading too ? anyone else ?
This patch can already be committed. This is the original bug report: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189879 Matthew Barnes is supposed to be working on the second part of the patch.
(In reply to comment #3) > Created an attachment (id=60326) [edit] > gtkhtml3-try-match-url-garbage-3.patch > > ' is an allowed character in a URL, so let's allow it in the regexp > Looks good to commit. Please commit with a ChangeLog.
Committed to gnome-2-14 and HEAD 2006-07-31 Bastien Nocera <hadess@hadess.net> reviewed by: Veerapuram Varadhan <vvaradhan@novell.com> * htmltext.c: Add "'" (single quote) as a possible character in a URL Fixes bug #327874