GNOME Bugzilla – Bug 327825
[matroskamux] Matroska muxer deadlock
Last modified: 2006-01-23 10:46:24 UTC
In the situation that matroska muxer is writing a buffer that already has EOS on collectpads, it is not assured that at least one buffer is popped in collectpads. This is a big problem especially near the end of stream, where matroska mux will not detect EOS correctly. I do not know how this could work for me so long....
Created attachment 57713 [details] [review]
Patch fixing matroska deadlock.
This is really a nasty problem, please could this patch be rewieved soon?
Thanks, applied to CVS with one minor modification: on EOS, the flow return value to be used is GST_FLOW_UNEXPECTED (admittedly not very intuitive):
2006-01-23 Michal Benes <michal dot benes at xeris dot cz>
* gst/matroska/matroska-mux.c: (gst_matroska_mux_best_pad),
Fix possible deadlock in matroska muxer (#327825).
Now what would be really neat is a small test case for this ... :)