After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327788 - Search for *all* files by leaving the search entry blank
Search for *all* files by leaving the search entry blank
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Search Interface
3.1.x
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-01-20 03:01 UTC by jsc
Modified: 2012-07-20 12:24 UTC
See Also:
GNOME target: ---
GNOME version: 3.1/3.2


Attachments
proposed patch (631 bytes, patch)
2011-01-26 15:00 UTC, Stefano Teso
none Details | Review
proposed patch, take 2 (4.76 KB, patch)
2011-01-29 13:33 UTC, Stefano Teso
none Details | Review
corrected patch (4.13 KB, patch)
2011-01-31 10:26 UTC, Stefano Teso
none Details | Review

Description jsc 2006-01-20 03:01:07 UTC
in accordance to gnome-search-tool, in simple (no beagle) search, leaving the
search entry void should search for all files. Currently nothing is searched.

Other information:
Comment 1 Allan Day 2010-05-25 14:20:03 UTC
Thanks for the report. We will be reviewing our search functionality this release cycle and will decide about this then.
Comment 2 Allan Day 2010-07-06 10:09:15 UTC
Actually, I agree with this. Setting to new.
Comment 3 Stefano Teso 2011-01-26 15:00:57 UTC
Created attachment 179374 [details] [review]
proposed patch

Patch to special case the '*' characted (instead of an empty string) to search for all files.

The problem with leaving the entry empty is that several places in the code assume that it _can't_ be empty. If the current approach is not acceptable, I will attempt to fix the code to allow for an empty string.

Please review.
Comment 4 Stefano Teso 2011-01-29 13:33:33 UTC
Created attachment 179588 [details] [review]
proposed patch, take 2

Okay, new patch that implements the required behavior: now searching an empty string (i.e., just leaving the search text entry empty and pressing enter) searches for all files.

I have not attempted to fix the tracker-based search engine to simulate the same behavior, partially because I have zero knowledge of sparql, partially because the tracker-based search does FTS instead of matching filenames.

It might be worth checking that nautilus_query_to_xml does the right thing when query_text = "", however.
Comment 5 Stefano Teso 2011-01-31 10:26:44 UTC
Created attachment 179704 [details] [review]
corrected patch

I managed to mess up with git while generating the previous patch; fixed patch attached.
Comment 6 André Klapper 2011-08-11 19:00:03 UTC
Fixing the summary as this is not about using "*" for the search (bug 340332).
Still valid in 3.1.4
Comment 7 William Jon McCann 2012-07-20 12:24:26 UTC
The new search in master works this way.