After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327765 - [sunaudio] fixes for mixer and stuttering mp3 playback
[sunaudio] fixes for mixer and stuttering mp3 playback
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
Other opensolaris
: Normal normal
: 0.10.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2006-01-19 22:27 UTC by Brian Cameron
Modified: 2006-01-23 11:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch to fix sunaudio GStreamer 0.10 plugin (1.50 KB, patch)
2006-01-19 22:30 UTC, Brian Cameron
committed Details | Review

Description Brian Cameron 2006-01-19 22:27:41 UTC
I noticed two bugs with the sunaudio plugin:

1) The mixer applet didn't work when I first tested it with the new 
   mixer applet.  I found that this was caused because some functions were
   defined as being "static" where they shouldn't be.  The mixer applet works
   fine after making these minor changes

2) The sunaudiosink plugin had the same stuttering problem I noticed earlier
   with sinesrc when I tested it with the new Fluendo MP3 plugin.  Bumping up
   the buffer from 3000000 to 5000000 fixes this problem.  I understand that 
   we need to look further into this to determine if this is a problem with
   the GStreamer engine or with the underlying SunAudio interface.  However,
   for now this minor change makes GStreamer work reasonably on Solaris with
   the MP3 plugin, which is nice.  For now, let's commit this change as a 
   workaround until we have a better understanding of why this is needed.

Attached patch to fix the sunaudiosink plugin in 0.10.
Comment 1 Brian Cameron 2006-01-19 22:30:42 UTC
Created attachment 57676 [details] [review]
patch to fix sunaudio GStreamer 0.10 plugin
Comment 2 Tim-Philipp Müller 2006-01-23 11:09:19 UTC
Applied, thanks! (I took the liberty of fixing up the comment above the magic 3ms value as well):

2006-01-23  Brian Cameron  <brian dot cameron at sun dot com>

        * sys/sunaudio/gstsunaudiomixerctrl.c:
        * sys/sunaudio/gstsunaudiosink.c: (gst_sunaudiosink_init):
          Export functions that are needed in other parts of the code,
          makes the mixer actually work; adjust magic minimum buffer-time
          value from 3ms to 5ms to work around stuttering during mp3
          playback (#327765).