GNOME Bugzilla – Bug 327662
Import BookmarkFile from libegg
Last modified: 2011-02-18 15:49:38 UTC
Tracker bug for importing the desktop bookmark parser object, needed by the RecentManager.
Also, the BookmarkFile could be used for the FileChooser bookmarks.
Created attachment 57627 [details] [review]
glue against glib HEAD
Glue needed for the GBookmarkFile stuff to compile against GLib HEAD
Created attachment 57628 [details]
Created attachment 57629 [details]
New version, including the remarks done during the review. there also is a test suite and the template for the reference documentation.
Created attachment 61948 [details]
the GBookmarkFile API
Created attachment 61949 [details]
the GBookmarkFile implementation
Created attachment 61950 [details] [review]
glue against GLib HEAD
glue for the build system
Created attachment 61951 [details]
test suite for GBookmarkFile.
there are also a bunch of invalid/valid files, like the ones we have in tests/markups that might be added.
Created attachment 61952 [details]
GBookmarkFile doc template
template for gtk-doc containing a description of GBookmarkFile and of the format.
Emanuele, thanks for all that work. I'll try to review it by Monday...
It looks all good to me. Can you commit it ?
It would be great if you could add a tests/bookmarks subdirectory with some
valid and invalid examples, and add a little shell script like we have for
the markup stuff.
Also, please add something like "The GBookmarkFile parser was added in GLib
2.10." at the end of the long description.