After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327202 - GtkButton::child-spacing style property
GtkButton::child-spacing style property
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-01-16 13:09 UTC by Michael Natterer
Modified: 2011-02-04 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch implementing the above (3.39 KB, patch)
2006-01-16 13:10 UTC, Michael Natterer 		none Details | Review
There we go (3.79 KB, patch)
2006-01-16 13:50 UTC, Michael Natterer 		none Details | Review

Description Michael Natterer 2006-01-16 13:09:51 UTC 
Attached patch turns the hardcoded CHILD_SPACING define into a
configurable style property. It's used in maemo-gtk and it IMHO
absolutely makes sense on high-dpi displays.
Comment 1 Michael Natterer 2006-01-16 13:10:37 UTC 
Created attachment 57470 [details] [review]
Patch implementing the above
Comment 2 Matthias Clasen 2006-01-16 13:24:02 UTC 
Makes sense to me. It needs a "Since: 2.10". For that you need to add an explicit 
doc comment for the property (see gtktoolbar.c for examples). And I'd prefer to 
remove the CHILD_SPACING define and just put the value in the paramspec constructor.
Comment 3 Michael Natterer 2006-01-16 13:50:51 UTC 
Created attachment 57471 [details] [review]
There we go
Comment 4 Matthias Clasen 2006-01-16 13:57:33 UTC 
Looks fine, go ahead.
Comment 5 Michael Natterer 2006-01-16 14:50:06 UTC 
Fixed in CVS:

2006-01-16  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkbutton.c: applied patch from maemo-gtk which adds a
	child-spacing style property. Fixes bug #327202.
Comment 6 Tim Janik 2006-01-18 12:56:41 UTC 
this has now been changed to make use of GtkBorder instead:

2006-01-17  Michael Natterer  <mitch@imendio.com>

        * gtk/gtkbutton.c: remove the "child-spacing" style property again
        and add "inner-border" instead. That's far more flexible and
        "child-spacing" was a bad name anyway.