After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326970 - Toolbar Notifications Not In GNOME XChat
Toolbar Notifications Not In GNOME XChat
Product: xchat-gnome
Classification: Other
Component: general
Other Linux
: Normal enhancement
: ---
Assigned To: xchat-gnome maintainers
xchat-gnome maintainers
Depends on:
Reported: 2006-01-14 16:06 UTC by Sebastien Bacher
Modified: 2006-01-18 07:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

set urgency flag on nick highlighthing and private message (3.65 KB, patch)
2006-01-14 23:42 UTC, Guillaume Desmottes
committed Details | Review

Description Sebastien Bacher 2006-01-14 16:06:51 UTC
This bug has been opened on

"If XChat is to be replaced with xchat-gnome, here is one feature that is lacking: toolbar notification. In gaim and stock xchat, when your name is said in a chat, an urgent hint is sent to the toolbar. This is not so in xchat-gnome. Xchat-gnome does support system-tray notifications, but it would be nice to keep consitancy with xchat and gaim and send an urgent hint to the toolbar when your nick is said (or an option for it be created)."
Comment 1 Guillaume Desmottes 2006-01-14 18:18:49 UTC
The notification plugin do that.
Isn't it what you need?
Comment 2 Sebastien Bacher 2006-01-14 18:24:29 UTC
There is 2 plugins atm to use the notification area/libnotify but neither set the URGENT flag for the windows (which creates an effect on the windows list for GNOME)
Comment 3 Guillaume Desmottes 2006-01-14 18:53:27 UTC
Ok, sorry for misunderstanding.

Seems a good idea indeed to turn this flag.
Comment 4 Guillaume Desmottes 2006-01-14 19:17:38 UTC
In fact would not it be more interesting to do this in the main code rather than plugins ?
It seems a good idea to always have windows list highlighting when you receive a new private message or your nick is said on a channel.  Doesn't it ?
Comment 5 Sebastien Bacher 2006-01-14 21:44:37 UTC
right, that should be standard feature
Comment 6 Guillaume Desmottes 2006-01-14 23:42:55 UTC
Created attachment 57376 [details] [review]
set urgency flag on nick highlighthing and private message

	* src/fe-gnome/main-window.c:
	* src/fe-gnome/fe-gnome.c:
	  - Turn on window urgency flag when nick highlighting and
	    receive a private message. (#326970)
	  - Use gui.main_window instead of getting the main window
	    widget with glade_xml_get_widget().

I have a very strang problem with this hack.
- Connect on a channel
- With another x-g cite the nick of the other x-g.
- First x-g display notification icon and highlight in the windows list
- Switch to it. It stop to highlight but the tray icon doesn't disappear.
- reswitch again and then it disappears.

It seems than the first time, the plugin doesn't receive the focus-in-event signal and i don't understand why.
Comment 7 David Trowbridge 2006-01-18 07:59:57 UTC
It's because a lot of gtk signals require a gboolean return value (including focus-in-event), and you weren't returning anything.  Because of that, it uses whatever was in RAM/registers, which was sometimes stopping the signal from propagating further.

Fixed that and applied to svn, thanks!