GNOME Bugzilla – Bug 326960
hex box drawing for win32 and atsui backends of cairo
Last modified: 2006-06-07 18:09:02 UTC
The pangocairo-win32 and pangocairo-atsui backends need to support hex box drawing. That's pretty straightforward given the work that went in during bug #313551.
Pango can not show unknown characters of indic glyph. I find that there is not the code about supporting unknown glyph in indic module.
Created attachment 57900 [details] [review] show unknown glyph of indic I wrote a patch about supporting to show unknown glyph of indic. I only modified ./modules/indic/indic-fc.c
Thanks, committed after some change. Please do not use current bugreports for issues not directly related to them. This issue doesn't have anything to do with win32 or atsui... 2006-01-23 Behdad Esfahbod <behdad@gnome.org> * modules/basic/basic-fc.c: Set cluster only on base chars, like the Arabic module does. * modules/indic/indic-fc.c: Draw an unknown glyph on missing glyphs, like other modules do. (part of bug #326960, LingNing Zhang)
Richard, please test and feel free to commit to pango-1-12 branch. 2006-06-07 Behdad Esfahbod <behdad@gnome.org> Bug 326960 – hex box drawing for win32 and atsui backends of cairo Hans already fixed win32. * pango/pangocairo-atsuifont.c (compute_glyph_extents): Handle PANGO_GLYPH_UNKNOWN_FLAG.
Thanks! I've tested this and it builds and runs at least. I'm not sure what the expected output is, I tried putting some random unicode characters in an entry and got boxes (but no hex in them).
Ok, that's probably good enough for now. The basic-atsui shaper should be changed to use hexbox glyph ids for unknown glyphs...