GNOME Bugzilla – Bug 326520
Add Accessibility::Document
Last modified: 2006-07-19 10:23:40 UTC
Implement Accessibility::Document per http://gnome.org/%7Ebillh/at-spi-new-idl/html/html/ AtkDocument, including document events (signals). Define circumstances and the order events should be fired. Includes document locale. Target Gnome 2.16 by the end of July 2006.
George: implementation (properly in gail) and definition are separate issues. ATK isn't the right component for this bug (since AtkDocument is already defined), though one might file an RFE against gail for a _specific_ gtk+ situation where document isn't currently being implemented as it should). Actually I think that with the possible exception of gedit, all the AtkDocument implementations will be outside of gail, i.e. OpenOffice.org, mozilla/gecko, etc. I'll keep this bug alive as the bug for "providing Accessibility::Document" which isn't in the at-spi IDL yet - it needs to wrap AtkDocument. As such, it belongs against component "at-spi", subcomponent "api". regards, Bill
Bill: should this bug be used to implement Document in libspi?
This bug should be used for the AtkDocument to Accessibility::Document wrapper in libspi. The changes should live in new files called (at-spi)/libspi/document.c (at-spi)/libspi/document.h Ariel should have a CVS account, should we assign this bug to him now? Bill
Created attachment 67348 [details] The above file describes the new interface in IDL. The file above should be added to cvs in the at-spi/idl directory, and Accessibility.idl and idl/Makefile.am edited accordingly.
Created attachment 67434 [details] Patch that implement document for at-spi Here are the patches with the document implementation. It includes both the libspi and cspi bindings. I revised them to fix the changes coming from the new Accessibility_Document.idl and comments by Bill.
What is the status on the code commit?
Ariel: Your patch looks good except for a couple of minor things. First, please don't use 'C++' style comments "//", they break some C compliers since they were introduced with C99 or later (not sure when). Secondly, it would be better to create patches using "diff -uN" to include new files, than to make .gz archives; that way the patch can be viewed/edited inline. One other thing (and this one is my fault): I think we should use AttributeSet as the return value from Document:getAttributes, instead of a delimited string. I will attach the modified IDL file.
Created attachment 68164 [details] [review] revised Document definition, returns attributes as an AttributeSet. should I go ahead and commit this now?
Bill, On the original IDL I used getAttributes returned AttributeSet. When I looked at your commited IDL I saw the method returned a string so I ma de the change. If you commit the IDL I'll resurrect the original code and repatch.
I've committed the new IDL Ariel... but there were some other issues with the patch, so I'm trying to fix it in my own workspace now. I'll let you know if it takes more than a few more minutes. Sorry for the mixup about the return value. In your patch, besides the format problem (patch -uN), it seems the necessary change to idl/Accessibility.idl was missing.
Created attachment 68169 [details] [review] revised patch, provides Document interface in libspi and cspi. Thanks Ariel for the initial version. Ariel, please commit after revising the ChangeLog. If I don't hear back from you in a couple of hours I'll commit myself. Next time should go smoothly! Thanks again.
Created attachment 68174 [details] [review] Patch with Changelog attached Bill: I have added my Changelog to he patch, I tryed to edit on bugzilla but I got a "you don't have permission" msg. Anyway, here it is. George told me that because of IBM policy I cannot do the commits myself even if I have my cvs account.
I committed the patch (with a minor change to fix missing Accessibility_Document.idl in idl_DATA, in idl/Makefile.am) and ChangeLog last night. It's in at-spi-1.7.8. Thanks Ariel for the work! Bill