After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326356 - Vertical raw rotation problems.
Vertical raw rotation problems.
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
0.1.5
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
: 344033 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-09 22:47 UTC by Artis Rozentāls
Modified: 2006-10-11 20:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes raw rotation for s60, probably breaks other cameras. (536 bytes, patch)
2006-06-07 18:25 UTC, Artis Rozentāls
committed Details | Review

Description Artis Rozentāls 2006-01-09 22:47:00 UTC
Verticaly taken raw images are shown upside down when viewing a single image, when browsing the thumbnails are unrotated.

Camera: Canon PowerShot s60
Comment 1 Larry Ewing 2006-01-10 01:55:46 UTC
can you attach an example image and tell me what version of dcraw you have installed?
Comment 2 Artis Rozentāls 2006-01-10 02:58:06 UTC
The raw is too big to attach. Does f-spot use an external dcraw binary?
Comment 3 Larry Ewing 2006-01-10 05:06:20 UTC
If all other methods of loading a suitable image fail it uses and external dcraw to load the image.  Newer dcraw versions apply rotations to the image when loading then f-spot does the same, which may be the cause of your problem.  In cvs f-spot passes more command line options to avoid this problem.  Can you reproduce this problem with cvs f-spot?

As far as attaching the image goes, feel free to mail it to me at lewing@novell.com
Comment 4 Artis Rozentāls 2006-01-10 14:08:30 UTC
The actual image displayed is the embeded jpeg in this case (image is identical to jpeg extracted with exiftool), CVS f-spot has same problem.
Comment 5 Bengt Thuree 2006-05-18 03:48:29 UTC
Does this still happend with latest cvs?
Did you send the picture to Larry?
Comment 6 Artis Rozentāls 2006-05-18 21:40:25 UTC
> Does this still happend with latest cvs?

Yes.

> Did you send the picture to Larry?

Back in january, I don't know if it arrived.
Comment 7 Artis Rozentāls 2006-06-07 18:25:15 UTC
Created attachment 66924 [details] [review]
Fixes raw rotation for s60, probably breaks other cameras.

I've managed to fix this for the PowerShot s60, but it probably breaks other cameras.
Comment 8 Larry Ewing 2006-06-08 21:22:31 UTC
what version of dcraw do you have installed?  Can you send me a sample raw file?
Comment 9 Artis Rozentāls 2006-06-08 21:51:56 UTC
None. As far as I can see f-spot doesn't use dcraw to display the raws, at least for PowerShot s60 raws it seems more like the embeded jpeg.

Sure, I just sent samples for 90 and 270 degrees to the address listed in CC.
Comment 10 Artis Rozentāls 2006-06-09 12:33:03 UTC
The Ximian address failed, message too large, I'll try the Novell address.
Comment 11 noa 2006-07-02 17:38:51 UTC
A sample can be downloaded from http://resare.com/noa/slask/raw-rotate-demo.crw (6.4MiB) the described behaviour (non-rotated thumbs, detailed view up side down) is reproducible with f-spot-0.1.11 from fedora development.
Comment 12 Alexandre Prokoudine 2006-09-22 07:39:56 UTC
This patch solves same issue for Canon 10D's CRW files and doesn't affect other files I have (350D's CR2 and JPEG).
Comment 13 Larry Ewing 2006-09-25 20:38:43 UTC
yeah the problem is that the internal processing in f-spot is reading the raw orientation and then using that orientation when displaying the embedded jpeg which is antually already in the correct orientation.  I need to improve the file abstraction so that this case can be handled properly.
Comment 14 Stephane Delcroix 2006-10-03 14:52:54 UTC
*** Bug 344033 has been marked as a duplicate of this bug. ***
Comment 15 Stephane Delcroix 2006-10-03 14:58:59 UTC
This bug was also reported in bug #344033 for 10D and 300D raw images.

To summarize:

-george submitted the bug and provided a lot of test raw pictures
-manuel came with a patch, similar to the one in comment #7
-larry said the actual cvs code worked well with his digital rebel (= 300D)
-I check the ciff specification, which clearly differ from f-spot code...

From the CIFF specification (http://xyrion.org/ciff/CIFFspecV1R04.pdf page 19), 
"rotationAngle: This indicates how many degrees in the counter-clockwise
direction the original data file should be rotated for correct viewing of the
image."

src/Ciff.cs "public int RotationAngle;  //degreess clockwise to rotate (orientation)"

Larry, or anybody owning a Digital Rebel, can you take some test shots ?
Comment 16 Nils Pickert 2006-10-09 09:29:55 UTC
Hi guys

I have the same problem with my pictures :-)

You can find a sample picture attached (taken with a EOS 300D) here:

https://launchpad.net/distros/ubuntu/+source/f-spot/+bug/63451

cheers
Nils
Comment 17 Larry Ewing 2006-10-11 20:50:13 UTC
I don't know what I was smoking, committing the patch.