After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326328 - "Copy files to Photos folder" should be preserved
"Copy files to Photos folder" should be preserved
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other All
: Normal enhancement
: 0.6.0
Assigned To: F-spot maintainers
F-spot maintainers
: 331386 332603 338574 346546 349404 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-09 17:53 UTC by Nico Kaiser
Modified: 2009-08-19 11:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for saving settings (2.41 KB, patch)
2007-07-28 20:35 UTC, Christoffer Sørensen
committed Details | Review

Description Nico Kaiser 2006-01-09 17:53:18 UTC
When importing a batch of photos, I have to select this checkbox "Copy files to
Photos folder" every time. I'd like this to be saved, or at least the default to
be *not* to copy the Photos.

I accidentally copied lots of Photos which I now have to re-import (annoying)...

BTW, the actual copying should be started not before I close the import dialog
with "Ok", not just after selecting the folder.

Other information:
Comment 1 Larry Ewing 2006-01-09 18:17:34 UTC
There is a long dicussion on the mailing list about this.
Comment 2 Bengt Thuree 2006-02-20 06:35:04 UTC
Perhaps put this in an Advance tab under Preferences? Default option Copy to Photos, or link to Original location

Also, the last location you imported from should be the default one. Perhaps even remember the last 10 different import locations...

Recommends to change from Bug to Enhancement Request.
Comment 3 Gabriel Burt 2006-03-02 02:27:11 UTC
*** Bug 332603 has been marked as a duplicate of this bug. ***
Comment 4 Gabriel Burt 2006-04-30 13:35:51 UTC
*** Bug 338574 has been marked as a duplicate of this bug. ***
Comment 5 Bengt Thuree 2006-05-18 02:50:33 UTC
Related comments in bug #338412
Comment 6 Bengt Thuree 2006-05-28 14:31:14 UTC
*** Bug 331386 has been marked as a duplicate of this bug. ***
Comment 7 Stephane Delcroix 2006-07-05 07:21:17 UTC
*** Bug 346546 has been marked as a duplicate of this bug. ***
Comment 8 Stephane Delcroix 2006-07-31 11:39:42 UTC
*** Bug 349404 has been marked as a duplicate of this bug. ***
Comment 9 Matthew East 2006-07-31 11:45:51 UTC
Thanks Stephane for spotting my duplicate.

I'd recommend the default to be:

* Copy to ~/Photos when importing from an external device
* Don't copy to ~/Photos when importing from the local hard drive
Comment 10 ghasd 2006-07-31 18:24:48 UTC
Please only a default one can configure. I really find this photo folder with all the sub dirs very uncomfortable.
Comment 11 apater 2006-08-07 21:43:01 UTC
I vote for:

1) Remember my last selection in the "copy files" option. If I deselected that option, it should still be deselected the next time I go there.

2) The 1st time f-spot runs, ask if I want to copy files or not. Then remember my answer.


I see from the mailing list discussion that the bug about copying the photos before getting a chance to deselect "copy files.." has been fixed.
Comment 12 Bengt Thuree 2006-09-24 01:45:28 UTC
Changing to enhancement
Comment 13 The Doctor What 2006-10-12 03:10:23 UTC
Here's my suggestion, based on what others have said + my own 2 cents:

  The "Copy..." option should be broken into a radio-button group:
   o Leave the images where it is now
   o Copy the images to <directory>
   o Move the images to <directory>

Below this group there should be a checkbox with label (depending on the media):
  [] Remember this option for removable media.
OR
  [] Remember this option for local files.

Cases:
  If the folder is on read-only media:
     "Move" should be grayed.
     If "Move" was the default, then "Copy" is default.
  If the folder is on removable media, then the "leave" option should have a warning; "This is removable media!"
  The defaults for remember is "Copy" for removable media and "Leave" for local files.

The defaults should be in the preferences someplace.  The preferences should mention that these can be changed whenever you import.

<directory> should be the top directory: ~/Photos
<directory> should be configurable in preferences.

I haven't tried to code in mono yet, but once I have, I'll submit patches.

Ciao!
Comment 14 Christoffer Sørensen 2007-07-28 19:31:31 UTC
I vote for the simplest possible solution.

Just save the last settings the user has made.

Regarding removable media: I think it is too much that such an option should be implemented.
Comment 15 Christoffer Sørensen 2007-07-28 20:35:59 UTC
Created attachment 92615 [details] [review]
Patch for saving settings

This patch saves the settings and loads them next time you start the import. I get hit by this bug http://bugzilla.gnome.org/show_bug.cgi?id=457480 but once that is fixed, you should be able to use this patch.
Comment 16 Ivan Zlatev 2008-07-31 06:57:29 UTC
+1 on remembering the previous state of the checkbox for Copy files...

What's the status of this bug? Any chance to get this in in the next version?
Comment 17 van.de.bugger 2008-12-26 19:22:18 UTC
Hey, what the decision? 

+1 for remembering last status of the checkbox.
Comment 18 Tim Zakharov 2009-07-04 02:20:54 UTC
I would prefer a dialog box the first time F-spot Import is run, then remember the setting the user chooses.  In my case, I keep my library of photos on an external drive, and import to local machine without copying photos over.  I must remember each time I import to UNcheck "Copy files to Photos folder" or I end up having to manually delete the photos that get copied into my home directory.  In particular, the first time I ran F-spot, with my library of 30,000 photos on my external drive, I didn't realize F-spot would copy them all to my home directory.  Many HOURS later, my home directory was now FULL.
Comment 19 Christoffer Sørensen 2009-07-04 11:45:05 UTC
There is already a patch here, so why is this major issue not fixed when the patch is so trivial?

2 years and counting.
Comment 20 Markus Lindqvist 2009-07-26 16:20:08 UTC
Created a merge request to fix this bug: http://gitorious.org/f-spot/mainline/merge_requests/1013

I hope this will be in the upcoming release. The import dialog still needs to be rewritten in the version after that.
Comment 21 Stephane Delcroix 2009-08-10 11:49:55 UTC
pushing this for now. all that import code is meant to be trashed and rewritten