Bug 326318 - fix qtdemux h264 avcC atom finding
fix qtdemux h264 avcC atom finding
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.x
Other Linux
: Normal normal
: 0.8.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2006-01-09 16:29 UTC by Ronald Bultje
Modified: 2006-01-30 13:45 UTC (History)
3 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.87 KB, patch)
2006-01-09 16:30 UTC, Ronald Bultje 		none Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Ronald Bultje 2006-01-09 16:29:59 UTC 
qtdemux doesn't skip unknown atoms while scanning for the avcC atom in the video header, so if the avcC is not the first atom, it will not work. Attached patch fixes this somewhat, although a rewrite of this part of qtdemux would be nicer, since it doesn't use the generic atom part finders...
Comment 1 Ronald Bultje 2006-01-09 16:30:23 UTC 
Created attachment 57045 [details] [review]
fix
Comment 2 Andy Wingo 2006-01-13 17:32:22 UTC 
Copying Edward so he can look at this for 0.10 as well
Comment 3 Edgard Lima 2006-01-18 18:58:10 UTC 
Ronald, Iv just commited your patch to 0.10 (qtdemux.c revision 1.105) pls test this with the files you have. Also pls make those files available some,. Thanks Very Much.
Comment 4 Ronald Bultje 2006-01-30 13:45:57 UTC 
applied to 0.8 CVS.
Note You need to log in before you can comment on or make changes to this bug.