Bug 326301 - make totem mozilla plugin seekbar work
make totem mozilla plugin seekbar work
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Browser plugin (obsolete)
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2006-01-09 14:48 UTC by Ronald Bultje
Modified: 2006-01-29 22:56 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
hi (2.41 KB, patch)
2006-01-09 14:48 UTC, Ronald Bultje 		needs-work Details | Diff | Review
blub (3.00 KB, patch)
2006-01-10 13:03 UTC, Ronald Bultje 		accepted-commit_now Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Ronald Bultje 2006-01-09 14:48:17 UTC 
Seekbar doesn't work, as in, it doesn't change value as movie progresses and it doesn't seek. Attached patch fixes a bug in totem-gst backend to make progressbar work and adds basic seeking code. Works in gst backend, rest untested.
Comment 1 Ronald Bultje 2006-01-09 14:48:35 UTC 
Created attachment 57035 [details] [review]
hi
Comment 2 Bastien Nocera 2006-01-09 22:23:25 UTC 
Looks alright, what's the change in the gst.c for though?
Comment 3 Ronald Bultje 2006-01-10 00:36:34 UTC 
Without it, -gst does not emit the tick event, and the slider does thus not update.
Comment 4 Bastien Nocera 2006-01-10 09:46:41 UTC 
That's because we don't unset the logo mode.
We should do that before opening the file, and set it again, and open the logo if loading the file fails.
Comment 5 Bastien Nocera 2006-01-10 09:50:04 UTC 
the problem is that you set the logo mode to be true in bacon_video_widget_new(), despite the default for the property being FALSE. This is for both the gst.c and gst-0.10.c backends
Comment 6 Ronald Bultje 2006-01-10 13:03:12 UTC 
Created attachment 57103 [details] [review]
blub
Comment 7 Bastien Nocera 2006-01-15 22:25:42 UTC 
Looks good.
Comment 8 Ronald Bultje 2006-01-29 22:56:11 UTC 
applied.
Note You need to log in before you can comment on or make changes to this bug.