Bug 326299 - totem mozilla plugin doesn't play asf
totem mozilla plugin doesn't play asf
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.8.x
Other All
: Normal normal
: 0.8.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2006-01-09 14:15 UTC by Ronald Bultje
Modified: 2006-01-30 13:46 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
add query to fdsrc (2.02 KB, patch)
2006-01-09 14:15 UTC, Ronald Bultje 		none Details | Diff | Review
protecting if for asfdemux (769 bytes, patch)
2006-01-09 14:16 UTC, Ronald Bultje 		none Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Ronald Bultje 2006-01-09 14:15:04 UTC 
Most asf files crash in the first second. Reason is mixup in bytestream for blocksize flushing because fdsrc doesn't implement query; attached patch adds query to fdsrc and also adds a workaround to asfdemux in case other sources have the same issue.
Comment 1 Ronald Bultje 2006-01-09 14:15:41 UTC 
Created attachment 57030 [details] [review]
add query to fdsrc
Comment 2 Ronald Bultje 2006-01-09 14:16:05 UTC 
Created attachment 57032 [details] [review]
protecting if for asfdemux
Comment 3 Andy Wingo 2006-01-13 17:31:18 UTC 
Patches look good.

0.10 fdsrc should handle queries properly because of basesrc. asfdemux will be rewritten to use getrange anyway so that fix doesn't apply to 0.10 either.
Comment 4 Tim-Philipp Müller 2006-01-14 10:29:47 UTC 
Slightly off-topic, but actually my (almost-ready-but-still-vapourware) gst-0.10 port of asfdemux is chain-based as well so far (with all memory-reads being protected by a size check though), otherwise it wouldn't work with network streams, would it? Adding a getrange() mode in addition should be fairly easy though.

Ronald, any reason you're not committing your fixes directly to the 0.8 branch? :-)
Comment 5 Ronald Bultje 2006-01-30 13:46:19 UTC 
Applied to 0.8 CVS.
Note You need to log in before you can comment on or make changes to this bug.