After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326285 - Port to GStreamer-0.10
Port to GStreamer-0.10
Product: gnome-applets
Classification: Other
Component: general
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 328786 (view as bug list)
Depends on:
Reported: 2006-01-09 10:31 UTC by Tim-Philipp Müller
Modified: 2010-01-24 01:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch to port code to GStreamer 0.10 (13.15 KB, patch)
2006-01-09 17:02 UTC, Tim-Philipp Müller
none Details | Review
gnome-applets-2.13.1-gst-010.patch (5.81 KB, patch)
2006-01-14 23:29 UTC, Saleem Abdulrasool
none Details | Review
gnome-applets-2.13.2-gst-010.patch (9.10 KB, patch)
2006-01-20 20:28 UTC, Saleem Abdulrasool
none Details | Review
$enableval to $withval to be consistent with AC_ARG_WITH (9.09 KB, patch)
2006-01-30 02:37 UTC, Sylvain BERTRAND
committed Details | Review

Description Tim-Philipp Müller 2006-01-09 10:31:36 UTC
The volume applet needs to be ported to GStreamer-0.10.

Patch will follow later today.
Comment 1 Rob Bradford 2006-01-09 13:47:55 UTC

*** This bug has been marked as a duplicate of 326257 ***
Comment 2 Rob Bradford 2006-01-09 13:51:53 UTC
Whoops. Sorry. Reopening bug. Although strongly dependent I can see this isn't an obvious dupe.
Comment 3 Tim-Philipp Müller 2006-01-09 17:02:04 UTC
Created attachment 57047 [details] [review]
patch to port code to GStreamer 0.10

I thought one bug per module would make things easier for the respective module maintainers :)

Attached patch ports the mixer applet to GStreamer-0.10. It requires gst-plugins-base from CVS as of today.

The patch has not had any testing (as I haven't got a complete 2.13 desktop to test with installed yet).
Comment 4 Saleem Abdulrasool 2006-01-14 23:29:44 UTC
Created attachment 57374 [details] [review]

Adds support for building against gstreamer-0.10 without dropping support for gstreamer-0.8
Comment 5 Tim-Philipp Müller 2006-01-15 15:37:47 UTC
It really does make sense to use gst_audio_default_registry_mixer_filter() for the 0.10 code path, as it handles mixers that do not implement the GstPropertyProbe interface (like e.g. osssink at the moment), which the current code does not.
Comment 6 Danielle Madeley 2006-01-20 10:53:24 UTC
Ronald says this patch can go in.

I assume attachment 57374 [details] [review] is meant to be applied after attachment 57047 [details] [review]. I haven't properly read through this patch, do we need 0.8 backwards compatibility?
Comment 7 Tim-Philipp Müller 2006-01-20 11:12:39 UTC
No, these are two different patches.

 * the first patch (mine) only ports to 0.10 without backwards compatibility for 0.8.
 * the second patch tries to accommodate both 0.8 and 0.10, but at the expense of not using new functionality from 0.10.

If you do not see the need to keep 0.8 compatibility, you should only need the first patch (however, someone should really test it first).

If you do want to keep 0.8 compatibility, I can create a new patch that cleanly separates the 0.8 and 0.10 code and doesn't have the drawbacks from the second patch. Not quite sure what the point of that is though; if there are any issues  with the 0.10 version, they should be fairly easy to fix. If time is a factor, however, the second patch can be applied and should work at least for the most common case (Linux/ALSA) for now.
Comment 8 Sebastien Bacher 2006-01-20 14:11:31 UTC
Some people may want to still use 0.8, other component have a build option, that would be nice to have a patch with both option and the code of the first one imho
Comment 9 Danielle Madeley 2006-01-20 16:19:55 UTC
I will personally test it tomorrow (although I'm very strapped for time before I fly).

What are the new features you are attempting to take advantage of in 0.10 that requires these changes? (I only have the most basic understanding of GStreamer.)

0.8 support while desirable is unlikely to be necessary if the rest of the desktop standardizes on 0.10, but doesn't also have a backwards compatibility option.
Comment 10 Saleem Abdulrasool 2006-01-20 20:28:07 UTC
Created attachment 57748 [details] [review]

This updated patch integrates Tim's code into the patch while maintaining backwards compatibility
Comment 11 Danielle Madeley 2006-01-27 03:13:32 UTC
*** Bug 328786 has been marked as a duplicate of this bug. ***
Comment 12 Danielle Madeley 2006-01-27 03:15:57 UTC
Tim, Ronald, can I get your thoughts on this latest patch?
Comment 13 Tim-Philipp Müller 2006-01-27 09:40:26 UTC
Looks good to me (Saleem: thanks for doing the work to combine the patches), but I haven't had a chance to try it yet (my laptop's harddrive with the 2.13 setup just died a few days ago).

One minor thing I noticed: in the AC_ARG_WITH(gstreamer,...  block in, the help message should probably be changed from --enable-gstreamer to --with-gstreamer to match the AC_ARG_WITH.
Comment 14 Sylvain BERTRAND 2006-01-30 02:37:16 UTC
Created attachment 58366 [details] [review]
$enableval to $withval to be consistent with AC_ARG_WITH
Comment 15 Danielle Madeley 2006-01-30 07:31:12 UTC
Should this be gstreamer-plugins-base-0.10 or gstreamer-base-0.10? I don't have the first one available on my system.
Comment 16 Danielle Madeley 2006-01-30 11:40:30 UTC
This is committed with some reworking of