GNOME Bugzilla – Bug 326257
[PATCH] Add support for gstreamer-0.10 in control center
Last modified: 2006-01-15 21:56:20 UTC
Please describe the problem:
The attached proposed patch enables support for Gstreamer 0.10.
Steps to reproduce:
Does this happen every time?
Created attachment 56997 [details] [review]
Attaching proposed patch
Patch looks generally fine, and it's nice that you can select between 0.8 and 0.10.
However, one problem with this patch (and the original code) is that it won't work with mixer elements that don't support the GstPropertyProbe interface (like the OSS mixer at the moment). Can be fixed by adding that to the element(s) in question of course, but the detection should still work without IMHO.
Also, since more or less the same mixer detection code is used in several gnome modules and generally useful for other apps/desktops as well, I was going to move it into a utility function in libgstaudio from gst-plugins-base.
Created attachment 57013 [details] [review]
patch to port code to GStreamer 0.10
Another patch. Throws out all 0.8 code and requires gst-plugins-base from CVS as of this morning. (It's easy enough to fix to keep the 0.8 option as the other patch though, but I don't quite see the point of that)
*** Bug 326285 has been marked as a duplicate of this bug. ***
Created attachment 57365 [details] [review]
Updates to include Tim's patch while allowing backwards compatibility.
Cool, I was meaning to combine them as well, but hadn't gotten around to it yet.
One minor thing: the requirements for 0.10 should probably be 0.10.1.1 (which is the CVS version between 0.10.1 and 0.10.2), at least until a new core/gst-plugins-base release 0.10.2 has been made, which is expected for ~Monday.
Thanks for your effort on that. I would like to push the change before tarballs from next week but current version doesn't build. On top of the CVS with ./autogen.sh --enable-gstreamer=0.10 && make it breaks on:
"../gnome-settings-daemon/actions/.libs/libacme.a(acme-volume-gstreamer.o): In function `_acme_set_mixer':/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:235: undefined reference to `gst_mixer_list_tracks'
:/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:238: undefined reference to `gst_mixer_track_get_type'
:/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:240: undefined reference to `GST_MIXER_HAS_FLAG'
../gnome-settings-daemon/actions/.libs/libacme.a(acme-volume-gstreamer.o): In function `acme_volume_gstreamer_open':/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:289: undefined reference to `gst_audio_default_registery_mixer_filter'
../gnome-settings-daemon/actions/.libs/libacme.a(acme-volume-gstreamer.o): In function `acme_volume_gstreamer_set_mute':/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:94: undefined reference to `gst_mixer_set_mute'
:/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:109: undefined reference to `gst_mixer_set_volume'
../gnome-settings-daemon/actions/.libs/libacme.a(acme-volume-gstreamer.o): In function `acme_volume_gstreamer_set_volume':/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:194: undefined reference to `gst_mixer_set_volume'"
Using "GST_LIBS="$GST_LIBS -lgstinterfaces-0.10 -lgstaudio-0.10"" like Tim's patch fixes the issue
grumpf, no it doesn't fix the issue...
Created attachment 57417 [details] [review]
Fixes 2 typos of the previous patch, uses "-lgstinterfaces-0.10 -lgstaudio-0.10", requires new version for gst_audio_default_registry_mixer_filter()
Patch commited, thank you for your work on that