After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326257 - [PATCH] Add support for gstreamer-0.10 in control center
[PATCH] Add support for gstreamer-0.10 in control center
Product: gnome-control-center
Classification: Core
Component: Sound
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Reported: 2006-01-09 02:32 UTC by Saleem Abdulrasool
Modified: 2006-01-15 21:56 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

control-center-2.13.4-gst-0.10.patch (4.04 KB, patch)
2006-01-09 02:44 UTC, Saleem Abdulrasool
none Details | Review
patch to port code to GStreamer 0.10 (6.05 KB, patch)
2006-01-09 09:48 UTC, Tim-Philipp Müller
none Details | Review
control-center-2.13.4-gst.0.10.patch (5.21 KB, patch)
2006-01-14 21:11 UTC, Saleem Abdulrasool
needs-work Details | Review
new patch (5.92 KB, patch)
2006-01-15 18:02 UTC, Sebastien Bacher
committed Details | Review

Description Saleem Abdulrasool 2006-01-09 02:32:41 UTC
Please describe the problem:
The attached proposed patch enables support for Gstreamer 0.10.

Steps to reproduce:

Actual results:

Expected results:

Does this happen every time?

Other information:
Comment 1 Saleem Abdulrasool 2006-01-09 02:44:07 UTC
Created attachment 56997 [details] [review]

Attaching proposed patch
Comment 2 Tim-Philipp Müller 2006-01-09 09:42:39 UTC
Patch looks generally fine, and it's nice that you can select between 0.8 and 0.10.

However, one problem with this patch (and the original code) is that it won't work with mixer elements that don't support the GstPropertyProbe interface (like the OSS mixer at the moment). Can be fixed by adding that to the element(s) in question of course, but the detection should still work without IMHO.

Also, since more or less the same mixer detection code is used in several gnome modules and generally useful for other apps/desktops as well, I was going to move it into a utility function in libgstaudio from gst-plugins-base.

Comment 3 Tim-Philipp Müller 2006-01-09 09:48:35 UTC
Created attachment 57013 [details] [review]
patch to port code to GStreamer 0.10

Another patch. Throws out all 0.8 code and requires gst-plugins-base from CVS as of this morning. (It's easy enough to fix to keep the 0.8 option as the other patch though, but I don't quite see the point of that)
Comment 4 Rob Bradford 2006-01-09 13:47:55 UTC
*** Bug 326285 has been marked as a duplicate of this bug. ***
Comment 5 Saleem Abdulrasool 2006-01-14 21:11:10 UTC
Created attachment 57365 [details] [review]

Updates to include Tim's patch while allowing backwards compatibility.
Comment 6 Tim-Philipp Müller 2006-01-14 21:37:49 UTC
Cool, I was meaning to combine them as well, but hadn't gotten around to it yet.

One minor thing: the requirements for 0.10 should probably be (which is the CVS version between 0.10.1 and 0.10.2), at least until a new core/gst-plugins-base release 0.10.2 has been made, which is expected for ~Monday.

Comment 7 Sebastien Bacher 2006-01-15 15:00:25 UTC
Thanks for your effort on that. I would like to push the change before tarballs from next week but current version doesn't build. On top of the CVS with ./ --enable-gstreamer=0.10 && make it breaks on:

"../gnome-settings-daemon/actions/.libs/libacme.a(acme-volume-gstreamer.o): In function `_acme_set_mixer':/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:235: undefined reference to `gst_mixer_list_tracks'
:/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:238: undefined reference to `gst_mixer_track_get_type'
:/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:240: undefined reference to `GST_MIXER_HAS_FLAG'
../gnome-settings-daemon/actions/.libs/libacme.a(acme-volume-gstreamer.o): In function `acme_volume_gstreamer_open':/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:289: undefined reference to `gst_audio_default_registery_mixer_filter'
../gnome-settings-daemon/actions/.libs/libacme.a(acme-volume-gstreamer.o): In function `acme_volume_gstreamer_set_mute':/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:94: undefined reference to `gst_mixer_set_mute'
:/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:109: undefined reference to `gst_mixer_set_volume'
../gnome-settings-daemon/actions/.libs/libacme.a(acme-volume-gstreamer.o): In function `acme_volume_gstreamer_set_volume':/tmp/gnome-control-center/gnome-settings-daemon/actions/acme-volume-gstreamer.c:194: undefined reference to `gst_mixer_set_volume'"
Comment 8 Sebastien Bacher 2006-01-15 16:25:11 UTC
Using "GST_LIBS="$GST_LIBS -lgstinterfaces-0.10 -lgstaudio-0.10"" like Tim's patch fixes the issue
Comment 9 Sebastien Bacher 2006-01-15 17:34:41 UTC
grumpf, no it doesn't fix the issue...
Comment 10 Sebastien Bacher 2006-01-15 18:02:49 UTC
Created attachment 57417 [details] [review]
new patch

Fixes 2 typos of the previous patch, uses "-lgstinterfaces-0.10 -lgstaudio-0.10", requires new version for gst_audio_default_registry_mixer_filter()
Comment 11 Sebastien Bacher 2006-01-15 21:56:20 UTC
Patch commited, thank you for your work on that