After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 326237 - leaks in the goption code
leaks in the goption code
Status: RESOLVED FIXED
Product: libgnome
Classification: Deprecated
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: libgnome maintainer
libgnome maintainer
Depends on:
Blocks:
 
 
Reported: 2006-01-08 21:15 UTC by Kjartan Maraas
Modified: 2006-01-09 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libgnome+libbonoboui+libgnomeui patch (10.08 KB, patch)
2006-01-08 22:46 UTC, Christian Persch 		none Details | Review

Description Kjartan Maraas 2006-01-08 21:15:55 UTC 
Valgrind reports this all over the place:

==24454== 293 (52 direct, 241 indirect) bytes in 1 blocks are definitely lost in loss record 4,583 of 5,399
==24454==    at 0x401F5D6: calloc (vg_replace_malloc.c:278)
==24454==    by 0x4D18A3B: g_malloc0 (gmem.c:139)
==24454==    by 0x4D1FA7C: g_option_group_new (goption.c:1600)
==24454==    by 0x44B1AAC: gtk_get_option_group (gtkmain.c:585)
==24454==    by 0x428CB97: bonobo_ui_gtk_module_info_get (bonobo-ui-init-gtk.c:181)
==24454==    by 0x428CF11: libbonobo_ui_module_info_get (bonobo-ui-main.c:288)
==24454==    by 0x422D514: libgnomeui_module_info_get (gnome-ui-init.c:166)
==24454==    by 0x807A692: main (nautilus-main.c:328)
==24454==
==24454==
==24454== 216 (52 direct, 164 indirect) bytes in 1 blocks are definitely lost in loss record 4,585 of 5,399
==24454==    at 0x401F5D6: calloc (vg_replace_malloc.c:278)
==24454==    by 0x4D18A3B: g_malloc0 (gmem.c:139)
==24454==    by 0x4D1FA7C: g_option_group_new (goption.c:1600)
==24454==    by 0x431B074: libgnome_module_info_get (gnome-init.c:538)
==24454==    by 0x428CF28: libbonobo_ui_module_info_get (bonobo-ui-main.c:291)
==24454==    by 0x422D514: libgnomeui_module_info_get (gnome-ui-init.c:166)
==24454==    by 0x807A692: main (nautilus-main.c:328)
==24454==
==24454==
==24454== 216 (52 direct, 164 indirect) bytes in 1 blocks are definitely lost in loss record 4,587 of 5,399
==24454==    at 0x401F5D6: calloc (vg_replace_malloc.c:278)
==24454==    by 0x4D18A3B: g_malloc0 (gmem.c:139)
==24454==    by 0x4D1FA7C: g_option_group_new (goption.c:1600)
==24454==    by 0x431B074: libgnome_module_info_get (gnome-init.c:538)
==24454==    by 0x431A6A6: gnome_bonobo_module_info_get (gnome-init.c:99)
==24454==    by 0x428CF3F: libbonobo_ui_module_info_get (bonobo-ui-main.c:294)
==24454==    by 0x422D514: libgnomeui_module_info_get (gnome-ui-init.c:166)
==24454==    by 0x807A692: main (nautilus-main.c:328)
==24454== 216 (52 direct, 164 indirect) bytes in 1 blocks are definitely lost in loss record 4,589 of 5,399
==24454==    at 0x401F5D6: calloc (vg_replace_malloc.c:278)
==24454==    by 0x4D18A3B: g_malloc0 (gmem.c:139)
==24454==    by 0x4D1FA7C: g_option_group_new (goption.c:1600)
==24454==    by 0x431B074: libgnome_module_info_get (gnome-init.c:538)
==24454==    by 0x41FC347: gnome_client_module_info_get (gnome-client.c:1055)
==24454==    by 0x422D52B: libgnomeui_module_info_get (gnome-ui-init.c:169)
==24454==    by 0x807A692: main (nautilus-main.c:328)
Comment 1 Christian Persch 2006-01-08 21:56:58 UTC 
-> me
Comment 2 Christian Persch 2006-01-08 22:46:42 UTC 
Created attachment 56988 [details] [review]
libgnome+libbonoboui+libgnomeui patch

With this patch I don't see those leaks anymore.
Comment 3 Kjartan Maraas 2006-01-09 07:35:03 UTC 
Should I just drop the previous patch then?
Comment 4 Christian Persch 2006-01-09 10:42:05 UTC 
Yes, this completely replaces it.
Comment 5 Kjartan Maraas 2006-01-09 13:29:09 UTC 
Compiling it now.
Comment 6 Kjartan Maraas 2006-01-09 20:03:16 UTC 
Commited.