GNOME Bugzilla – Bug 326054
Add "Live" tag editing in entry views
Last modified: 2018-05-24 11:02:43 UTC
I have some suggestion about the tag editing: -The Right-Click->Preference way of editing tags doesn't seem very explicit, (this is the first time that I compile rhythmbox with tag editing and I wasn't able if after the compilation) so I think that there is probable better to give. In fact all the information that appears on the preference dialaog is shown on the list, so I thik that is better a "live" editing (I don't know if this is the best name). I think that an "Edit" entry that allow the user to directly edit the information on the list is more intuitive. The "Edit" entry should expose the same dialog that Propierties does when multiple files are selected, because you can't do batch editing on the list directly. -I think that in the propierties dialog we should show the information that is not shown on the list only, and not everything (having in mind that we have editing support on the list already). -Instant editing on Album and Artist specific lists should be allowed as a way of batch editing, sometimes I have collections of music with bad unicode in the artists name and editing directly on the artists list is far easy than select all the songs in the edit menu (or pressing Ctr+A if you already know the keybinding) and then Right-click->Propierties. -The multiple files propierties dialog (batch editing) doesn't show the common titles if there are, for example, if I select five songs from Nirvana, Nirvana doesn't appear on the Artist entry. -If I edit all the files from one album or artist, and change that propierty, that album (or artist) still in the collection, but empty. -If I do simple or batch editing and I change the artist, the selection disappear, so if I type something wrong, it's hard to know where the files went. The interface should keep the selection shown even if they change the location rather than make them desappear. Other information: I think that that's all, I don't know If I should file this suggestion as various bugs, so sorry If I'm doing wrong.
(In reply to comment #0) > -The Right-Click->Preference way of editing tags doesn't seem very explicit, > (this is the first time that I compile rhythmbox with tag editing and I wasn't > able if after the compilation) so I think that there is probable better to > give. > In fact all the information that appears on the preference dialaog is shown on > the list, so I thik that is better a "live" editing (I don't know if this is > the > best name). I think that an "Edit" entry that allow the user to directly edit > the information on the list is more intuitive. The "Edit" entry should expose > the same dialog that Propierties does when multiple files are selected, because > you can't do batch editing on the list directly. Bug 76524 discusses how to improve the dialog for tag-editing, however I think this sound like a nicer way of doing it. > -I think that in the propierties dialog we should show the information that is > not shown on the list only, and not everything (having in mind that we have > editing support on the list already). Different people have different columns visible, which would make it hard to show only properties that aren't in the list. I think it is also nice to have all the information available there. > -Instant editing on Album and Artist specific lists should be allowed as a way > of batch editing, sometimes I have collections of music with bad unicode in the > artists name and editing directly on the artists list is far easy than select > all the songs in the edit menu (or pressing Ctr+A if you already know the > keybinding) and then Right-click->Propierties. I'm fairly sure there is already a bug for this, but I can't seem to find it. It should be relative easy to implement, now that our tag-editing work a little better. Adding a context menu to the artist/album browsers with a "Rename" item would be a fairly good way of doing it. > -The multiple files propierties dialog (batch editing) doesn't show the common > titles if there are, for example, if I select five songs from Nirvana, Nirvana > doesn't appear on the Artist entry. That's a bug. I'm fairly sure we fixed it, but it must have gotten broken again without anyone noticing. > -If I edit all the files from one album or artist, and change that propierty, > that album (or artist) still in the collection, but empty. This is bug 323086. > -If I do simple or batch editing and I change the artist, the selection > disappear, so if I type something wrong, it's hard to know where the files > went. > The interface should keep the selection shown even if they change the location > rather than make them desappear. Unfortunately, figuring out what to change the browsers/search box to, to stop this happening, is a difficult problem. If we did the album/artist rename item above, you probably wouldn't be doing this too often anyway. > Other information: > I think that that's all, I don't know If I should file this suggestion as > various bugs, so sorry If I'm doing wrong. In general it's better to file them seperately, as it makes it easier to keep track of which ones have been fixed and which ones haven't.
Created attachment 56963 [details] [review] patch for filling in multiple song info This patch fixes the problem with filling in the fields of the multiple song properties window (although it doesn't set the rating box).
(In reply to comment #1) > > -If I do simple or batch editing and I change the artist, the selection > > disappear, so if I type something wrong, it's hard to know where the files > > went. > > The interface should keep the selection shown even if they change the location > > rather than make them desappear. > > Unfortunately, figuring out what to change the browsers/search box to, to stop > this happening, is a difficult problem. If we did the album/artist rename item > above, you probably wouldn't be doing this too often anyway. Correct me if I'm wrong, but, If the user do batch editing, you can get the string of the propierty changed, and select that album, artist or so, in the browser after commit the changes. ¿It is really so difficult? > In general it's better to file them seperately, as it makes it easier to keep > track of which ones have been fixed and which ones haven't. I'm very sorry, this is one of my first bug reports, seems that I need to improve my use of bugzilla.
Patch committed to cvs. Not showing properties that are visible in columns: WONTFIX "Rename" option in context menu for artists/albums: split into bug 326583 Filling in fields of multiple-track edit dialog: FIXED Artist/Album not disappearing from browser: bug 323086 I'm retitling the bug to reflect the remaining request: "Live" tag editing.
it has been 9 years, probably a WONTFIX at this point right?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/115.