GNOME Bugzilla – Bug 325957
Needs to #define LDAP_DEPRECATED when compiling against openldap 2.3.x
Last modified: 2013-09-14 16:49:07 UTC
The newer OpenLDAP releases deprecated some of the functions that are being used by e-d-s and Evolution. To be able to access them without getting "implicit declaration of foo()" you have to check for the new version and #define LDAP_DEPRECATED if building against it. e-book-backend-ldap.c: In function 'check_schema_support': e-book-backend-ldap.c:527: warning: implicit declaration of function 'ldap_get_values' e-book-backend-ldap.c:527: warning: assignment makes pointer from integer without a cast e-book-backend-ldap.c:562: warning: implicit declaration of function 'ldap_value_free' e-book-backend-ldap.c: In function 'get_ldap_library_info': e-book-backend-ldap.c:594: warning: implicit declaration of function 'ldap_init' e-book-backend-ldap.c:594: warning: assignment makes pointer from integer without a cast e-book-backend-ldap.c:624: warning: implicit declaration of function 'ldap_unbind' e-book-backend-ldap.c: In function 'query_ldap_root_dse': e-book-backend-ldap.c:670: warning: assignment makes pointer from integer without a cast e-book-backend-ldap.c:679: warning: assignment makes pointer from integer without a cast e-book-backend-ldap.c:692: warning: assignment makes pointer from integer without a cast e-book-backend-ldap.c:717: warning: assignment makes pointer from integer without a cast e-book-backend-ldap.c:722: warning: assignment makes pointer from integer without a cast e-book-backend-ldap.c: In function 'e_book_backend_ldap_connect': e-book-backend-ldap.c:758: warning: assignment makes pointer from integer without a cast e-book-backend-ldap.c:822: warning: implicit declaration of function 'ldap_simple_bind_s' e-book-backend-ldap.c: In function 'ldap_op_finished': e-book-backend-ldap.c:1009: warning: implicit declaration of function 'ldap_abandon' e-book-backend-ldap.c: In function 'build_contact_from_entry': e-book-backend-ldap.c:3439: warning: assignment makes pointer from integer without a cast e-book-backend-ldap.c:3469: warning: assignment makes pointer from integer without a cast e-book-backend-ldap.c: In function 'e_book_backend_ldap_authenticate_user': e-book-backend-ldap.c:4046: warning: implicit declaration of function 'ldap_search_s' e-book-backend-ldap.c: At top level: e-book-backend-ldap.c:4379: warning: 'stop_views' defined but not used e-book-backend-ldap.c:4398: warning: 'start_views' defined but not used
adding dep. this should be fixed in the 1.5 timeframe.
I agree, is anything happening here?
Created attachment 61893 [details] [review] patch
looks good to commit.
I'm going to commit this so it doesn't miss another cycle :-)