GNOME Bugzilla – Bug 325831
grammar error in calendar message
Last modified: 2013-09-13 01:00:01 UTC
Please describe the problem: #: ../calendar/calendar.error.xml.h:62 msgid "You have changed this appointment, but not yet saved them. so it should be either You have changed this appointment, but not saved *it* (the appointment) or You have made changes to this appointment, but not saved *them* (the changes) NOTE: compare the similar message for tasks: #: ../calendar/calendar.error.xml.h:63 msgid "You have made changes to this task, but not yet saved them." These two messages should probably obtain the same wording if possible. Steps to reproduce: 1. N/A Actual results: Expected results: Does this happen every time? Other information:
Thanks for the bug report.
according to chen on irc, first message is better
I agree with chen then, because in the second frase, it might perhaps look like as if the changes themselves would be saved. So: the messages should be as follows: (adding the word 'yet' which I had ommitted mistakenly earlier) #: ../calendar/calendar.error.xml.h:62 msgid "You have changed this appointment, but not yet saved it. #: ../calendar/calendar.error.xml.h:63 msgid "You have changed this task, but not yet saved it." I don't know how to make a patch for this however, so someone else will have to do that i'm afraid. Thanks for looking into this.
timo: no problem, i'm going to care about this. <commercial spot> however, *if* you're interested in writing patches, check out http://developer.gnome.org/tools/cvs.html and evolution's patch guidelines at http://www.gnome.org/projects/evolution/patch.shtml :-) </commercial spot>
Created attachment 57259 [details] [review] corrects two dialog messages in calendar.error.xml makes the frasing of two dialog messages consistent and grammatically correct
Ok, thanks for the links Andre, i've checked out the evolution module and created a patch. (my very first ever patch! whoohoo). Please tell me if I did it the correct way. (I used cvs diff -u -p calendar.error.xml whilst in the evolution/calendar/ directory) However, looking into the source shed a new light on the two messages: The dialog contains a primary and secondary message: primary: Would you like to save your changes to this appointment? secondary: You have changed this appointment, but not yet saved them. and primary: Would you like to save your changes to this task? secondary: You have made changes to this task, but not yet saved them. I still think that turning both secondary messages into the form: You have changed this foo, but not yet saved it. is the best way to go, but I'm not a native english speaker so i may be wrong.
hey tino, congrats, the patch looks pretty good(TM), but it misses a changelog entry. :-) (check out the corresponding ChangeLog file, in this case "evolution/calendar/ChangeLog", add your chance on top, and also put it into the existing patch file by using "file >> patch" instead of "file > patch".) so either you add one, or i can do that for you - i'm just asking because i would use your email address as above for that and perhaps you would like to see another address of yours used because of spam issues or something like that. happy patching, :-) andre
Well, I knew I needed some coaching... I'll work on a revised patch, with the changlog patch included, tomorrow. The e-mail I use here, is fine to use in the patch. I use it for almost everything (so yes, I receive lot's of spam, but it's not unworkable). But thank you for being so considerate. Tino
Ok, here's a new patch, now including a Changelog entry. I guess once the patch is accepted, a message to the gnome-i18n@gnome.org mailinglist needs to be sent too?
Created attachment 57886 [details] [review] revised patch including changelog entry
hi tino, sorry that it took me so long - now i went ahead and committed your fix: http://cvs.gnome.org/viewcvs/evolution/calendar/ChangeLog?r1=1.2960&r2=1.2961 http://cvs.gnome.org/viewcvs/evolution/calendar/calendar.error.xml?r1=1.14&r2=1.15 i have sent a message both to gnome-i18n@gnome.org and gnome-doc-list@gnome.org (both is needed). thanks very much, closing this as fixed. :-)