After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 325490 - fdsink ported to 0.10.x
fdsink ported to 0.10.x
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
Other All
: Normal enhancement
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2006-01-02 09:14 UTC by Philippe Rouquier
Modified: 2006-02-06 21:39 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Patch against 0.10.0 (13.79 KB, patch)
2006-01-02 09:33 UTC, Philippe Rouquier
none Details | Review
patch v2 (12.98 KB, patch)
2006-01-02 13:59 UTC, Philippe Rouquier
none Details | Review
patch v3 against 0.10.1 (16.85 KB, patch)
2006-01-04 17:18 UTC, Philippe Rouquier
none Details | Review

Description Philippe Rouquier 2006-01-02 09:14:57 UTC
I've ported fdsink to 0.10.x and would like people to comment on it
Comment 1 Philippe Rouquier 2006-01-02 09:33:21 UTC
Created attachment 56655 [details] [review]
Patch against 0.10.0
Comment 2 Philippe Rouquier 2006-01-02 09:47:15 UTC
Just a note about the above patch : apply it inside gstreamer-0.10.0 directory with "patch -p1".
Comment 3 Philippe Rouquier 2006-01-02 10:06:55 UTC
Last note : while at it I added the possibility to query position
Comment 4 Edward Hervey 2006-01-02 11:10:47 UTC
The commited patch is against, it should be against .

Also, fdsrc is conditionnaly compiled if there's a socket.h (#if HAVE_SYS_SOCKET_H), shouldn't it be the case for fdsink too ?

Finally, if you could, you might want to implement the GstURIHandler interface, it's not complicated to implement (see the bottom of fdsrc.c, using the same protocol, but with GST_URI_SINK).
Comment 5 Philippe Rouquier 2006-01-02 13:59:03 UTC
Created attachment 56664 [details] [review]
patch v2

The patch is against 0.10.1 now and against
It adds GstURIHandler interface.
But it is still not conditionally compiled since we don't use socket. Should we ?
Comment 6 Philippe Rouquier 2006-01-04 17:18:49 UTC
Created attachment 56781 [details] [review]
patch v3 against 0.10.1

This patch add a control socket since we need one to prevent blocking fds from causing trouble when changing state.
Comment 7 Jan Schmidt 2006-01-30 22:00:29 UTC
Committed in CVS, thanks for the patch!

        * plugins/elements/
        * plugins/elements/gstelements.c:
        * plugins/elements/gstfdsink.c: (_do_init),
        (gst_fd_sink_base_init), (gst_fd_sink_class_init),
        (gst_fd_sink_init), (gst_fd_sink_dispose), (gst_fd_sink_query),
        (gst_fd_sink_render), (gst_fd_sink_check_fd), (gst_fd_sink_start),
        (gst_fd_sink_stop), (gst_fd_sink_unlock), (gst_fd_sink_update_fd),
        (gst_fd_sink_set_property), (gst_fd_sink_uri_get_type),
        (gst_fd_sink_uri_get_protocols), (gst_fd_sink_uri_get_uri),
        (gst_fd_sink_uri_set_uri), (gst_fd_sink_uri_handler_init):
        * plugins/elements/gstfdsink.h:
        Port fdsink to 0.10 (patch by Philippe Rouquier) (Fixes #325490)