After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 325431 - clearlooks handle looks bad with vertical panel
clearlooks handle looks bad with vertical panel
Status: RESOLVED FIXED
Product: gtk-engines
Classification: Deprecated
Component: clearlooks
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Stellingwerff
gtk-engines maintainers
Depends on: 159764 329228
Blocks:
 
 
Reported: 2006-01-01 08:21 UTC by Allison Karlitskaya (desrt)
Modified: 2006-04-09 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot of the effect with CVS HEAD clearlooks and gnome-panel (3.01 KB, image/png)
2006-01-01 08:22 UTC, Allison Karlitskaya (desrt) 		  Details
Figure out orientation from handle dimensions (1.29 KB, patch)
2006-01-10 23:02 UTC, Ray Strode [halfline] 		none Details | Review

Description Allison Karlitskaya (desrt) 2006-01-01 08:21:09 UTC 
the clearlooks handle looks bad when drawn on a vertical panel.
Comment 1 Allison Karlitskaya (desrt) 2006-01-01 08:22:36 UTC 
Created attachment 56624 [details]
screenshot of the effect with CVS HEAD clearlooks and gnome-panel
Comment 2 Ray Strode [halfline] 2006-01-10 23:02:56 UTC 
Created attachment 57134 [details] [review]
Figure out orientation from handle dimensions

So there are a few weirdnesses going on:

- when painting the handle, gnome-panel passes ORIENTATION_HORIZONTAL for top panels and bottom panels, and ORENTATION_VERTICAL for left panels and right panels; that's backward.
- clearlooks just hard codes horizontal = FALSE, regardless of what's passed in
- other widgets that draw handlebox handles (for instance gtkhandlebox) just ignore the orientation argument anyway and always pass in VERTICAL.

So I'd say the orientation argument is pretty useless when drawing handlebox handles.  It's probably better to just figure out the orientation from the dimensions of the handle getting drawn.
Comment 3 Matthias Clasen 2006-01-11 17:11:38 UTC 
If the panel gets it wrong, then it needs to be fixed.
Regardless of any guesswork being added to theme engines...
Comment 4 Matthias Clasen 2006-01-11 17:19:04 UTC 
It also affects other theme engines, I saw issues with at least Lush and Glider 
in a quick check. One more argument for fixing rather than working around.
Comment 5 Vincent Untz 2006-02-12 11:55:37 UTC 
I don't think the panel does it backwards: it works well with the Simple theme...
Comment 6 Allison Karlitskaya (desrt) 2006-04-09 18:31:55 UTC 
This is fixed now.