Created attachment 56268 [details] [review]
patch file to add ilbcenc, ilbcparse and ilbcdec to gst-plugins-ugly/gst

++votes to add it :)

A lot of applications are using iLBC audio Codec, such as Skype, GnomeMeeting, Asterisk, and certainly it will be used by tapioca-voip, farsight, and others!
Vote to add it!

this has been pending for a while now. Will target for 0.10.3

wtay,

In addition to the solution proposed above (in which the iLBC codec code is inside a folder inside gst-plugin- tree) I have two other approaches:
1- Im just waiting sourceforge to aprove my libilbc project
2- Put a README file teaching step-by-step, people that wants to compile/use iLBC codec plugin, how to download the iLBC codec source code and compile together with the plugin (almost the same thing as the patch in this Bug, the diference is that people will have to download it if they want)

what do you think?

Having a separate lib outside of the gstreamer plugin repository is preferable. Also marking as enhancement.

didn't make the freeze, retargetting

Can this patch be merged now?

It would be good to have a unanimous solution to this bug and   http://bugzilla.gnome.org/show_bug.cgi?id=333307 and also amrnb

btw: I tried to create a project in sourceforge but it wasn't accepted because of iLBC license.

still not done, retargetting to HEAD.

Hi, in the patch the capabilities for ilbcenc and ilbcdec are 'audio/iLBC' and not 'audio/x-iLBC', the caps used by rtpilbcdepay and rtpilbcpay. ilbcdec/ilbcenc can't be used with actual ilbc payloader/depaylorder.
Regards.

New plugins go in -bad first. Re-assigning.

Any news on this?

So there's probably no interest in this anymore? I'll close this bug as WONTFIX then.

If someone disagrees, Edgard's original patch still needs some changes to be acceptable. It should at least contain a README that explains how to get the ilbc sources but better should use some external library. And then we need a patch against gst-plugins-bad.

In general having a reference ILBC end/dec is wanted. But I agree, it needs work. E.g. the parser should be a baseparse parser and should be bundled with other parsers. Then the codecs could go to ugly (unless we find a different implementation).

I'm afraid that even if we had another implementation, the patent licensing would still force it in ugly.

Google has released the iLBC implementation under the BSD license as part of RTCWeb, they even include a free patent license: http://sites.google.com/site/webrtc/license-rights

I'd like to revive this, bring it to 2011 standards and maybe get it merged

Created attachment 192818 [details] [review]
ilbc: Add reference iLBC encoder and decoder

I took Edgar's patch and adapted it to 2011 GStreamer style. Also, the parser doesn't seem to work, I'm not sure exactly how it should work. I guess, ideally we could have an external library for the iLBC code.

Also, the reference iLBC code operates on floats, but the WebRTC version is int, so we should probably use that one. That said, I fnid it very useful to have a wrapper for the reference implementation, as it makes it easier to validate 3rd party "optimized" implementations.

Please let's get this out of bugzilla now :P

Ideally port it to the audio/parser base classes first and put it into 0.10/0.11 -good or -ugly. Or put it into -bad as is and merge an unported version to 0.11.

So...? Olivier? :)

Ping? No interest anymore? :)

Comment on attachment 192818 [details] [review]
ilbc: Add reference iLBC encoder and decoder

Need to be ported to 1.0

Let's close this then, there seems to be no need for this decoder anymore or at least nobody interested in porting it to 1.0