Just found out that Drac card lib has a pretty good algorithm for a windows-like animation, in case somebody wants to have a look at it for Aisleriot.
http://drac-cardlib.sourceforge.net/

2¢: Today's neat WinSolitaire-knockoff ending is tomorrow's corny and outdated ending... This type of feature was originally mentioned back in Bug #2845, and ruled as WONTFIX since nobody working on aisleriot at the moment had any intention of fixing nor doing this. While some newer effects may be possible soon (via cairo), I'd still be against it since the novelty factor wouldn't outweigh the fact that almost anything we do would neither be very impressive and gratifying for us nor the users. It's just solitaire. :)

I too am against a flash animation sequence - Richard's analysis is bang on here. However the dialog is a little visually subdued; not to mention the excessive use of exclamation marks to try tarting it up. Mines has the same problem - especially when the score doesn't make the top ten. I'm going to keep the bug open because the "you have won" dialog does need to be improved, but an animation isn't the answer.

A bright icon in the dialog might be a good idea, but not one of the stock warning/information/etc... ones.

First of all - animation was only a suggestion. It's not a crusade I will be fighting.
What is important with a game is the feeling you get when you're done. If it's something "rewarding", you will feel that the whole game has been rewarding. When it's a disappointment, you will feel you have played "in vain". Yes, I realize that all games are in vain. But still. 
I personally think that something else than a dialog is to be preferred. Perhaps a picture something, combined with a sound (some kind of happy but short beep, and not one of the default dialog ones.).
It's the little things that matter. In mines - it's the smiley face suddenly wearing glasses. It just makes you feel good! Perhaps something like a picture of a King wearing glasses would be cool?

Also - I don't think animation should be dismissed a priori. As long as it can easily be clicked away, it will provide an element of excitement the first couple of time a player wins. And I think that even though the ending might get corny and outdated tomorrow, it will still have been worth to have it today. Cause the ending we have now is corny and outdated today. And to be frank - the whole idea of solitaire is corny and outdated. Yet people still play it, cause it's relaxing! 

I agree that knocking off Windows isn't the best thing. Perhaps there could be some cool scaling and/or rotating effect, now that the cards are SVG and there's cairo to do cool things with them. Much cooler things can be done now than were done in Windows, and it is a good opportunity to show things off.

In any way - I'm happy to hear that you're going to at least fix up the victory dialog, just a fixed grammar and a different icon (and some different sound too, plz) will do much!

For all the games, how about a genric gold trophy (cup-shaped) for first place, silver for 2nd, bronze for 3rd... Show the trophy at the top of the dialog if they win the top spots, and maybe a blue ribbon or something if they complete but don't place. 

Animation could be tiny bits of confetti falling behind it ;)

This idea was inspired by playing entirely too much Monkey Ball last week.

I was thinking of something relatively simple - a gold trophy had certainly sprung to mind. It could be placed at the usual icon place on the non-scoring dialogs. I think we only need to indicate top-ten/non-top-ten for the scoring games. I certainly don't like the "Unfortunately your score didn't make the top ten" I currently have in Mines. Having an icon on the scores dialog indicating a top-ten place would certainly work.

I've fixed the exclamation mark problem. Leaving the bug open as a generic must-make-end-of-game-dialog-more-exciting-bug.

Great! Did you by any chance change the icon too?

Confirming the bug so it doesn't bother triagers, and setting priority to low. Hope that's ok with you.

Also - as a total sidenote and a cute anecdote - I thought of this bug when I watched my 2 year old cousin laugh with joy at seeing the cards fly when I won at solitaire on my N770. I know it's not an argument, but a funny observation I thought I'd share now that I was making changes to the bug anyway...

The icon won't be going in this time around. If I had realised that UI freeze was Mondays release rather than the release two weeks ago I might have got it in. In the long run I'd like to create a standard dialog for all the games to use.

As far as animations and two year olds go, my experience is that they are very easily amused. Wait until they turn four, then they'll play Frogger with the explicit mission of killing the frog. Thats what my cousin did anyway.

Aisleriot svn plays a 'victory' sound on win.

*** Bug 407742 has been marked as a duplicate of this bug. ***

Re-assigning to default owner.

I also think it'd be nice if it would let you re-play the same game over from the start.

Oh, also, I'm using the Aisleriot in Fedora 13 (gnome-games 2.30) and I think it'd be great if it also displayed the score in the end-of-game dialogue box.

Mass-moving only open aisleriot bugs to the new product. Search for "aisleriot-mass-move" to filter them.

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/aisleriot/-/issues/64.