After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324480 - Selecting first item with keyboard is difficult
Selecting first item with keyboard is difficult
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
2.8.x
Other All
: Normal normal
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
: 303669 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-12-19 10:35 UTC by Murray Cumming
Modified: 2006-05-28 23:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
patch to provide described keynav behavior for treeviews (3.08 KB, patch)
2005-12-19 12:02 UTC, bill.haneman
none Details | Review

Description Murray Cumming 2005-12-19 10:35:08 UTC
Please describe the problem:


Steps to reproduce:
1. Open a folder (in browse mode)
2. Press the down arrow key
3. Notice that the accessibility focus is on the first item (outline around the
row), but not the selection (highlighted row).
4. Press the down arrow key again.
5. Now the second item is selected.
6. Press the up arrow key again.
7. Now the first item is finally selected, but I expected this at 3.


Actual results:


Expected results:


Does this happen every time?


Other information:
This was discussed/improved slightly in this (hard to follow) bug, which made it
possible to select a single item with two down arrow presses:
http://bugzilla.gnome.org/show_bug.cgi?id=131226
Comment 1 bill.haneman 2005-12-19 10:49:45 UTC
Murray, I believe this is a dup of 131226 in fact.  At least, IMO the patch for 131226 is the correct fix for this problem, as it :

1) makes it possible to navigate to the list (including a list containing only one item) without selecting it; and
2) makes the selection of the first item in a list consistent with selecting other items in a list.

Bill
Comment 2 Murray Cumming 2005-12-19 11:09:16 UTC
> I believe this is a dup of 131226

But that bug is closed, and I am using the latest stuff.

> 1) makes it possible to navigate to the list

This is not about making it possible. (That is done and I am grateful.) This is about making is not strange.

> makes the selection of the first item in a list consistent with selecting
other items in a list.

It's strange in both cases, because of step 3. above.
Comment 3 bill.haneman 2005-12-19 11:50:35 UTC
Murray:

Ah, then some patch didn't get applied (maybe this is a dup of a _different_ bug), since we (Sun) are using a patch which causes selection of the FIRST item to occur at step 5 (rather than selection of the _second_ item).

If selection of the first item occurred at step 3, there would be no way to keyboard navigate through/past a list without causing a selection to occur, which is not desirable.
Comment 4 bill.haneman 2005-12-19 12:02:18 UTC
Created attachment 56153 [details] [review]
patch to provide described keynav behavior for treeviews

patch may require some tweaking to apply to HEAD, as it's a gnome-2.6 patch.
Comment 5 Murray Cumming 2005-12-19 12:10:21 UTC
> If selection of the first item occurred at step 3, there would be no way to
> keyboard navigate through/past a list without causing a selection to occur,
> which is not desirable.

Maybe it's desirable for treeviews in which changes of selection have no great effect, which would be most of them. I guess you do this lots, but could we have a quick example?
Comment 6 bill.haneman 2005-12-19 12:14:28 UTC
File choosers are an example where making a selection matters, and also the theme capplet is a prime example.  There are lots of others but I can't think of them offhand - I only recall LOTS of gnopernicus problem reports that turned out to be keynav issues in the treeview, because blind users doing tab navigation were selecting stuff that shouldn't be selected.

Comment 7 Murray Cumming 2005-12-19 12:24:12 UTC
Ah, I guess the problem is that, for instance, blind users move the accessibility focus just to see what's there, but subsequent operations would be affected by an inadvertent selection if they did that while also automatically changing the selection.

Wow. I've just noticed that the accessibility focus thing doesn't even appear when accessibility support is turned off. That's nifty.
Comment 8 bill.haneman 2005-12-19 12:32:15 UTC
Really?  What "focus thing" ?

It shouldn't change depending on the "accessibility" key, that key is actually for "assistive technology support" and is not needed by keynav-only user who aren't using a screenreader.  If you're right, then that's another bug.
Comment 9 Murray Cumming 2005-12-19 12:40:38 UTC
(On Ubuntu Dapper),
- with accessibility support turned on:
a down arrow in a Nautilus window moves the accessibility outline focus thing moves to the first item and a second down causes the second item to be highlighted, as described.
- with accessibility supported turned off:
a down arrow in a Nautilus window highlights the first selection. Ctrl-Arrow can still be used to move the accessibility outline focus thing.
 
Comment 10 Murray Cumming 2005-12-19 12:41:28 UTC
Note that a re-login is necessary to change the behaviour, so it's not just checking a gconf key.
Comment 11 Matthias Clasen 2005-12-19 17:31:23 UTC
Murray, what you are talking about is called the "cursor" in treeview terminology.
Comment 12 bill.haneman 2005-12-19 17:42:16 UTC
Hi Matthias:

I think both behaviors reported by Murray are wrong, in different ways.  I also think that the behavior should not change noticeably when the assistive technology gconf keys (aka the 'accessibility' key) is toggled.

While in some cases it may seen more convenient to "select on focus", I think consistency arguments win the day in favor of making the treeview not select on focus, but only select on subsequent arrow key presses.
Comment 13 Matthias Clasen 2005-12-21 14:08:50 UTC
I am not seeing that dependency on a11y being turned on. 
That must be some Ubuntu patch if it is the case.

I'll ask jrb what he thinks about the change proposed in #4
Comment 14 Murray Cumming 2005-12-21 15:02:49 UTC
> I am not seeing that dependency on a11y being turned on. 
> That must be some Ubuntu patch if it is the case.

I don't see it now either. I swear it was so. It must have been some temporary bug solved by an update.

So, this bug is just about the patch in #4.
Comment 15 Kristian Rietveld 2006-05-28 22:48:09 UTC
*** Bug 303669 has been marked as a duplicate of this bug. ***
Comment 16 Kristian Rietveld 2006-05-28 23:35:14 UTC
Reworked the patch, also the shift key will start at the current focus row now.  Committed to HEAD.