After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324216 - [cdparanoia] missing patches from 0.8
[cdparanoia] missing patches from 0.8
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
Other Linux
: Normal normal
: 0.10.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2005-12-15 20:32 UTC by Loïc Minier
Modified: 2006-01-02 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description Loïc Minier 2005-12-15 20:32:27 UTC

It seems some fixes were not forward ported to 0.10, at least the following
cdparanoia fix seems to be missing:

--- gst-plugins/ext/cdparanoia/gstcdparanoia.c>-2005/09/06 13:12:28>----
+++ gst-plugins/ext/cdparanoia/gstcdparanoia.c>-2005/09/30 21:32:00>----
@@ -546,7 +546,7 @@
   /* stop things apropriatly */
-  if (src->cur_sector > src->segment_end_sector) {
+  if (src->cur_sector >= src->segment_end_sector) {
     GST_DEBUG ("setting EOS");
     buf = GST_BUFFER (gst_event_new (GST_EVENT_EOS));

I've been told to file this bug as a reminder that some fixes might be missing.

Comment 1 Wim Taymans 2005-12-19 16:32:21 UTC
yep, sorry about that, I'm merging the other 0.8 stuff into it now.
Comment 2 Tim-Philipp Müller 2005-12-27 22:08:29 UTC
Just an update: the reason this hasn't been merged in yet is that there's going to be a cddabasesrc class for the cd audio sources which will have those fixes and additions and which will be committed Really Soon Now (tm).
Comment 3 Tim-Philipp Müller 2006-01-02 16:48:30 UTC
Should be fixed in CVS now (the base class handles most of this stuff now):

2005-12-29  Tim-Philipp Muller  <tim at centricular dot net>

        * ext/cdparanoia/
        * ext/cdparanoia/gstcdparanoia.c:
        * ext/cdparanoia/gstcdparanoia.h:
        * ext/cdparanoia/gstcdparanoiasrc.c:
        (gst_cd_paranoia_mode_get_type), (gst_cd_paranoia_src_base_init),
        (gst_cd_paranoia_src_init), (gst_cd_paranoia_src_class_init),
        (gst_cd_paranoia_src_open), (gst_cd_paranoia_src_close),
        (gst_cd_paranoia_src_read_sector), (gst_cd_paranoia_src_finalize),
        (gst_cd_paranoia_src_get_property), (plugin_init):
        * ext/cdparanoia/gstcdparanoiasrc.h:
          New cdparanoiasrc element based on cddabasesrc; enable cdparanoia
          plugin again (there are still fixes required to playbin to make
          cdda:// uris work there).