GNOME Bugzilla – Bug 324216
[cdparanoia] missing patches from 0.8
Last modified: 2006-01-02 16:48:30 UTC
Hi, It seems some fixes were not forward ported to 0.10, at least the following cdparanoia fix seems to be missing: --- gst-plugins/ext/cdparanoia/gstcdparanoia.c>-2005/09/06 13:12:28>----1.49.2.15 +++ gst-plugins/ext/cdparanoia/gstcdparanoia.c>-2005/09/30 21:32:00>----1.49.2.16 @@ -546,7 +546,7 @@ } /* stop things apropriatly */ - if (src->cur_sector > src->segment_end_sector) { + if (src->cur_sector >= src->segment_end_sector) { GST_DEBUG ("setting EOS"); buf = GST_BUFFER (gst_event_new (GST_EVENT_EOS)); I've been told to file this bug as a reminder that some fixes might be missing. Cheers,
yep, sorry about that, I'm merging the other 0.8 stuff into it now.
Just an update: the reason this hasn't been merged in yet is that there's going to be a cddabasesrc class for the cd audio sources which will have those fixes and additions and which will be committed Really Soon Now (tm).
Should be fixed in CVS now (the base class handles most of this stuff now): 2005-12-29 Tim-Philipp Muller <tim at centricular dot net> * configure.ac: * ext/cdparanoia/Makefile.am: * ext/cdparanoia/gstcdparanoia.c: * ext/cdparanoia/gstcdparanoia.h: * ext/cdparanoia/gstcdparanoiasrc.c: (gst_cd_paranoia_mode_get_type), (gst_cd_paranoia_src_base_init), (gst_cd_paranoia_src_init), (gst_cd_paranoia_src_class_init), (gst_cd_paranoia_src_open), (gst_cd_paranoia_src_close), (gst_cd_paranoia_paranoia_callback), (gst_cd_paranoia_src_read_sector), (gst_cd_paranoia_src_finalize), (gst_cd_paranoia_src_set_property), (gst_cd_paranoia_src_get_property), (plugin_init): * ext/cdparanoia/gstcdparanoiasrc.h: New cdparanoiasrc element based on cddabasesrc; enable cdparanoia plugin again (there are still fixes required to playbin to make cdda:// uris work there).