After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323905 - use return val of g_list_append
use return val of g_list_append
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2005-12-12 17:37 UTC by William Jon McCann
Modified: 2005-12-16 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (1.40 KB, patch)
2005-12-12 17:38 UTC, William Jon McCann
reviewed Details | Review

Description William Jon McCann 2005-12-12 17:37:18 UTC
It is necessary to use the return val of g_list_append.  Fixes the build for head.
Comment 1 William Jon McCann 2005-12-12 17:38:20 UTC
Created attachment 55903 [details] [review]
Comment 2 Tim-Philipp Müller 2005-12-12 18:24:21 UTC
That's a nice catch, I wonder about one more thing though: we do

   current_list = g_list_append (current_list, buf);

and then return TRUE. Shouldn't that be

   buffer->store = g_list_append (current_list, buf);

or something like that? What's the point of doing the append if we don't store
it somewhere for later? (Don't have time to look through the code right now,
just bringing it up as something to double-check)


Comment 3 Tim-Philipp Müller 2005-12-16 15:34:47 UTC
Has been fixed by Andy in CVS the same way as you suggested.

I guess GLib can't really change their internal implementation not to support
this, whatever the API docs say, but if they do we'll probably find out soon
enough anyway ;)

2005-12-16  Andy Wingo  <>

        * plugins/elements/gstbufferstore.c
        (gst_buffer_store_cleared_func): Pay attention to g_list_append
        return value.
        * tests/check/gst/gstobject.c
        (test_fake_object_name_threaded_unique): Pay attention to
        g_list_sort return value.