GNOME Bugzilla – Bug 323905
use return val of g_list_append
Last modified: 2005-12-16 15:34:47 UTC
It is necessary to use the return val of g_list_append. Fixes the build for head.
Created attachment 55903 [details] [review]
That's a nice catch, I wonder about one more thing though: we do
current_list = g_list_append (current_list, buf);
and then return TRUE. Shouldn't that be
buffer->store = g_list_append (current_list, buf);
or something like that? What's the point of doing the append if we don't store
it somewhere for later? (Don't have time to look through the code right now,
just bringing it up as something to double-check)
Has been fixed by Andy in CVS the same way as you suggested.
I guess GLib can't really change their internal implementation not to support
this, whatever the API docs say, but if they do we'll probably find out soon
enough anyway ;)
2005-12-16 Andy Wingo <email@example.com>
(gst_buffer_store_cleared_func): Pay attention to g_list_append
(test_fake_object_name_threaded_unique): Pay attention to
g_list_sort return value.