After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323900 - Basertpdepayloader lets NEWSEGMENT events through unfiltered
Basertpdepayloader lets NEWSEGMENT events through unfiltered
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.1
Assigned To: Philippe Khalaf
GStreamer Maintainers
Depends on:
Reported: 2005-12-12 17:16 UTC by Kai Vehmanen
Modified: 2005-12-18 01:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Adds sink event filtering. (2.67 KB, patch)
2005-12-12 17:19 UTC, Kai Vehmanen
none Details | Review
Adds sink event filtering (v2 of the patch). (2.42 KB, patch)
2005-12-13 14:29 UTC, Kai Vehmanen
none Details | Review

Description Kai Vehmanen 2005-12-12 17:16:41 UTC
Please describe the problem:
Basertpdepayloader adds a GST-timestamp to packets it processes, based on the
RTP timestamp. On the first packet, it generates a NEWSEGMENT event to notify
downstream of the start-TS for this stream.

In current CVS-HEAD, upstream NEWSEGMENT events are passed through the element,
causing confusion to downstream elements (they get NEWSEGMENT events with
different time formats).

Basertpdepayloader should make sure that NEWSEGMENT events that it passes
downstream, are all of the same format.

Steps to reproduce:

Actual results:

Expected results:

Does this happen every time?

Other information:
A patch, hopefully attached to this bug report later on.
Comment 1 Kai Vehmanen 2005-12-12 17:19:22 UTC
Created attachment 55901 [details] [review]
Adds sink event filtering.
Comment 2 Sebastien Cote 2005-12-12 19:01:04 UTC
I think you should unref the NEW_SEGMENT event in
gst_base_rtp_depayload_handle_sink_event() since you're dropping it.
Comment 3 Kai Vehmanen 2005-12-13 14:29:46 UTC
Created attachment 55943 [details] [review]
Adds sink event filtering (v2 of the patch).