After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323752 - gdk_parse_args doesn't check g_option_context_parse's result correctly
gdk_parse_args doesn't check g_option_context_parse's result correctly
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-12-10 20:38 UTC by Torsten Schoenfeld
Modified: 2011-02-04 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adding a ! (700 bytes, patch)
2005-12-10 20:38 UTC, Torsten Schoenfeld 		none Details | Review

Description Torsten Schoenfeld 2005-12-10 20:38:20 UTC 
gdk_parse_args lacks a ! in the check of g_option_context_parse's result.  Patch
attached.
Comment 1 Torsten Schoenfeld 2005-12-10 20:38:40 UTC 
Created attachment 55849 [details] [review]
Adding a !
Comment 2 Matthias Clasen 2005-12-10 21:48:25 UTC 
Argh
Comment 3 Torsten Schoenfeld 2005-12-10 23:34:23 UTC 
The gtk-2-8 branch doesn't seem to have this bug.  It looks like the ! got lost
between your commits to gtk-2-8 and HEAD:

gtk-2-8: http://cvs.gnome.org/viewcvs/gtk%2B/gdk/gdk.c?r1=1.162&r2=1.162.2.1

HEAD: http://cvs.gnome.org/viewcvs/gtk%2B/gdk/gdk.c?r1=1.163&r2=1.164

So there's probably no need to roll 2.8.10 just yet. :-)