GNOME Bugzilla – Bug 323400
Use 'folder' instead of 'directoy'
Last modified: 2006-09-26 18:27:11 UTC
It would be nice to use folder instead of directory in the strings of the pot file. Other information:
The Style Guide (http://developer.gnome.org/documents/style-guide/gnome-glossary-generic-terms.html) makes a distinction between the two, and goes so far as to give an example that uses both in a single (apparently user-facing) sentence, but I think you're right, that "directory" does not belong in F-Spot (although according to the style guide it may be appropriate when talking about the ~/Photos/ directory).
Here's a list of places that directory is used. Larry, what do you think about changing these all to "folder"? I think that, according to the style guide, we should keep the term directory where we also give the path, but use the term folder otherwise. CameraFileSelectionDialog.cs: Mono.Posix.Catalog.GetString ("Unable to create directory."), CameraFileSelectionDialog.cs: String.Format (Mono.Posix.Catalog.GetString ("Error \"{0}\" while creating directory \"{1}\". Check that the path and permissions are correct and try again"), e.Message, destination)); Exif.cs: return Mono.Posix.Catalog.GetString ("Image Directory"); Exif.cs: return Mono.Posix.Catalog.GetString ("Thumbnail Directory"); Exif.cs: return Mono.Posix.Catalog.GetString ("Exif Directory"); Exif.cs: return Mono.Posix.Catalog.GetString ("GPS Directory"); Exif.cs: return Mono.Posix.Catalog.GetString ("InterOperability Directory"); Exif.cs: return Mono.Posix.Catalog.GetString ("Unknown Directory"); GPhotoCamera.cs: throw new Exception (String.Format ("Directory \"{0}\"does not exist", filename)); //FIXME MainWindow.cs: Gtk.Window win = new Gtk.Window ("Directory View"); ImportCommand.cs: Mono.Posix.Catalog.GetString ("Directory does not exist."), ImportCommand.cs: String.Format (Mono.Posix.Catalog.GetString ("The directory you selected \"{0}\" does not exist. Please choose a different directory"), this.ImportPath));
the stuff in Exif.cs is not about the filesytem at all so it is outside this scope. The the things in ImportCommand and CameraFileSelectionDialog are reporting the full patch of something that is missing so they seem sane wrt using Directory as the term. And the instance in MainWindow is not actually used anywhere iirc. so I'm not too worried about any of this. Did you check the glade file for other possible problems?
So should we close this one, as WontFix
Created attachment 73271 [details] [review] one liner patch A small patch to replace the only occurance of Directory to Folder in f-spot.glade This replaces the f-spot --view --> Directory in the top left corner, with Folder.
fixed in CVS