After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323316 - GtkMessageBox should set empty window title by default
GtkMessageBox should set empty window title by default
Status: RESOLVED DUPLICATE of bug 310443
Product: gtk+
Classification: Platform
Component: Widget: Other
2.8.x
Other Linux
: High normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-12-05 22:10 UTC by Jaap A. Haitsma
Modified: 2006-05-08 21:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.11 KB, patch)
2005-12-17 14:25 UTC, Jaap A. Haitsma
none Details | Review

Description Jaap A. Haitsma 2005-12-05 22:10:05 UTC
According to the HIG
http://developer.gnome.org/projects/gup/hig/2.0/windows-alert.html

alerts should not have a window title. GtkMessageBox is used often for an alert.
Therefore it would be wise to default to an empty window title instead of now to
"Question", "Information" etc.
Comment 1 Jaap A. Haitsma 2005-12-17 14:25:19 UTC
Created attachment 56096 [details] [review]
patch
Comment 2 Jaap A. Haitsma 2005-12-27 03:53:11 UTC
Could somebody take a look at the attached patch please?
Comment 3 Jaap A. Haitsma 2006-01-26 20:17:46 UTC
Can somebody review the attached patch please? The patch is really simply it removes one line and it adds another
Comment 4 Tim Janik 2006-02-21 09:38:30 UTC
i don't think implementing this behaviour at the toolkit level is a good idea, rationale was given on gtk-devel-list:
  
  http://mail.gnome.org/archives/gtk-devel-list/2006-February/msg00155.html
Comment 5 Matthias Clasen 2006-02-21 13:33:28 UTC
Note that there is a more extensive HIGification patch in another bug whose
number eludes me at the moment, which includes this change.
Comment 6 Jaap A. Haitsma 2006-02-21 15:49:20 UTC
(In reply to comment #5)
> Note that there is a more extensive HIGification patch in another bug whose
> number eludes me at the moment, which includes this change.
> 
OK, let's wait for that one to land and then close this bug as well
Comment 7 Jaap A. Haitsma 2006-02-21 19:07:06 UTC
(In reply to comment #4)
> i don't think implementing this behaviour at the toolkit level is a good idea,
> rationale was given on gtk-devel-list:
> 
>   http://mail.gnome.org/archives/gtk-devel-list/2006-February/msg00155.html
> 
The patch doesn't enforce you to NOT have a window title. It's just not having one by default. Every developer can set the window title to whatever he or she wants

If you get 20 warning windows which have all as the title "Warning" it's also not terribly usefull.

Furthermore most of the times a gtk-message-dialog is used as a dialog of the app which does not appear in the window list, but is just modal with respect to the app
Comment 8 Jaap A. Haitsma 2006-05-08 21:39:33 UTC

*** This bug has been marked as a duplicate of 310443 ***