After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323108 - Reply, Reply, Reply
Reply, Reply, Reply
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.4.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Srinivasa Ragavan
Evolution QA team
Depends on:
Blocks: 323105
 
 
Reported: 2005-12-03 14:17 UTC by Karsten Bräckelmann
Modified: 2013-09-10 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (1.06 KB, patch)
2005-12-03 14:23 UTC, Karsten Bräckelmann
accepted-commit_now Details | Review

Description Karsten Bräckelmann 2005-12-03 14:17:31 UTC
The various Reply methods are totally confusing and named inconsistently.

The toolbar show the correct order and naming:
 Reply, Reply to All

The menu is heavily broken:
 "Reply" is named Reply to Sender (this one is fine [1])
 "Reply to All" is named Reply

The latter is *totally* broken and must be prperly named "Reply to All".


[1] It is a good idea to add additional informative text in the menu where we
got the space, but to leave it out on the toolbar, where it would waste way too
much screen real-estate.
Comment 1 Karsten Bräckelmann 2005-12-03 14:23:34 UTC
Created attachment 55573 [details] [review]
proposed fix

Properly renamed Reply to All, adding the menu shortkey back.
Comment 2 André Klapper 2005-12-05 14:25:15 UTC
confirm me, baby.
Comment 3 Srinivasa Ragavan 2005-12-12 16:46:46 UTC
guenther looks fine to commit. 
Comment 4 Karsten Bräckelmann 2005-12-12 17:30:07 UTC
I would be glad, if you could do this on my behalf again. Don't have the sources
here and pretty much no time. Would love to see this being committed for 2.5.3,
though.

Note: Other patches by me have been committed recently IIRC, affecting this
code. So this patch might not apply as-is any longer. Should be easy to adjust
this one-line patch, though. Feel free to poke me, if there are any issues with
this patch.
Comment 5 Srinivasa Ragavan 2005-12-13 07:02:43 UTC
Commited to head.