After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322975 - erroneous audio specs in flac plugin
erroneous audio specs in flac plugin
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2005-12-01 23:25 UTC by gcocatre
Modified: 2005-12-09 11:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Proposed fix (1.41 KB, patch)
2005-12-01 23:28 UTC, gcocatre
none Details | Review
Updated patch (1.86 KB, patch)
2005-12-02 11:38 UTC, Michael Smith
none Details | Review

Description gcocatre 2005-12-01 23:25:06 UTC
Version details: 0.9.7

* FLAC supports 1 to 8 channels: (the plugin
specifies 1-6)

* FLAC supports the following sampling rates
( 8, 16, 22.05, 24, 32,
44.1, 48 and 96kHz (the plugin specifies a range of 11025Hz-48000Hz).

* FLAC supports the following sample sizes, in bits
( 8, 12, 16, 20 and 24
bits (integer), and 32 bits (floating point, although not supported by the
reference encoder / decoder)
Other less usual sampling rates are also supposed to be supported, although they
are outside the scope of the "subset format" (whatever that means - read the
docs). Some DVD-Audio mixes are sampled at 88.2kHz, for instance.
Comment 1 gcocatre 2005-12-01 23:28:23 UTC
Created attachment 55503 [details] [review]
Proposed fix

Has been successfully tested on 24bit, 96kHz, stereo flac files. Multichannel
files somewhat work, although it seems that their higher sampling rate, the
more the audio output stutters, as if the buffer wasn't large enough.
Comment 2 Michael Smith 2005-12-02 11:38:11 UTC
Created attachment 55517 [details] [review]
Updated patch

Here's a fixed patch that actually implements support for the additional depths
you added, and for the full range of sampling rates the spec specifies.

Not committing yet; we're doing only critical bugfixes before 0.10, so expect
this in 0.10.1 unless you can convince others that this is ok.

Can you test the patch? I don't have any flac files.
Comment 3 gcocatre 2005-12-02 18:29:18 UTC
It works on the files I previously tested.
Comment 4 Michael Smith 2005-12-09 11:13:16 UTC
Patch committed; will be in 0.10.1