GNOME Bugzilla – Bug 322917
address selector uses shortcut keys multiple times
Last modified: 2007-12-04 10:12:28 UTC
Please describe the problem: The "Select Contacts from Addressbook" popup in mailer uses the A B C R shortcut keys multiple times which makes keyboard navigation annoying (in case you are wondering my touchpad is flakey) Steps to reproduce: 1. Compose a new message 2. Click the To|CC|BCC button 3. Look at the popup and wonder what the Ctrl [A|B|C|R] shortcuts will do 4. Scratch you head 5. Look at alternatives which include making mouse work properly Actual results: User gets annoyed with the actions of the shortcut keys and frustrated with the person who coded the popup Expected results: Each shortcut only be used once per "screen"/popup Dell to manufacture better touchpads on their overpriced laptops ;) Does this happen every time? Yes - in English at least Other information: Here is the list of shortcuts and their associated actions A - Add To, Add CC, Add BCC B - Address Book select list, BCC list box C - Contacts, CC, Close R - Remove To, Remove CC, Remove BCC I understand some of this is related to using the GTK standard buttons for Add/Remove so something else will break to fix parts of this :( Again, thanks for a great product and hope this report helps to improve it a little more.
oh my god, right. :-/ thanks for reporting this.
Sorry andre/Dave I didnt understand the bug. What CTRL ABCR. Can you explain me a bit more. I guess you have told a lot in this report. But what this shortcut is?
Hi Srinivasa, CTRL (aka the Control key) is usually located on the bottom left corner of a US-QWERTY keyboard A B C and R are letters of the latin alphabet Combining CTRL and one of A B C or R can be used a way of calling a function within the contacts popup within evo Mailer. This key combination is generally refered to as a "keyboard shortcut". I hope this clarified things. Cheers Dave
srini: take a look at that dialog and try to use the mnemonics, e.g. the one to "add". it's the same mnemonic for adding to cc, bcc, and to. i won't submit another screenshot.
Oh ok. btw, I didnt ask for a screenshot :-). I got it now. But as he said, we cant do much about those button, lemme do something about this.
no, you didn't ask for a screenshot, i was a bit ironical. please don't take it personally, dude. :-) we could rename the buttons - we'd perhaps have "add to to", "add to cc", "add to bcc" and hopefully find more possiblities to not have the same mnemonics over and over again. but this is a pretty hard one i would say, and i would also like to remove the 2.5 target and set this to 2.7, to be honest.
As Andre pointed out on IRC it is ALT [1] not CTRL as I originally said. Sorry for any confusion this may have caused. [1] The ALT key is located on the bottom left of a US-QWERTY keyboard, to the right of the CTRL key where there are 101 key, or 2 to the right of the CTRL where there are 104/5 keys.
dave, i was confused because of CTRL. Now things are clear. This may be bit complex since the gui is a plugin sort of code to generate buttons. Lemme see how to fix it. Im not sure, will i be able to may much attention in next 2 weeks or so.
also see bug 325725
Created attachment 57097 [details] new dialog andre, dave, I have done some changes. I couldnt remove '_Remove' as well as '_Close' duplication. I think this should be fine, but i wanted your opinions also. Have a look at the screenshot
Hi Srinivasa, Hmmmm. I see the duplication has been removed, but so too has the functionality. the shortcut keys are handy for all users and really needed for accessibility. As there is likely to be duplication or functionality loss with any modified version of the existing dialog, I think there needs to be more significant work done on this one as I am not sure how this can be handled :(
dave, can u explain what functionality u think thatz removed? I didnt remove any. Just _T _C _B will add, and remove will work as such. What is removed? Can u explain bit more on this?
*** Bug 331156 has been marked as a duplicate of this bug. ***
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
removing old target milestone.
Created attachment 100047 [details] [review] Patch resolves mnemonics conflicts This patch fixes the conflicts between the mnemonics in question. It follows most of Srinivasa's earlier patch. Unfortunately, I couldn't remove the duplication between the Cc: and Close mnemonic, and the Add/Remove buttons had their mnemonics removed. If this is a problem, then the mnemonics can be re-added, but this will force the user to cycle between the buttons when they try to use the mnemonic.
Hi Alex, thanks for patch. From my point of view, it's better to have any mnemonic than none (without them, you should press TAB, which goes over all widgets, which is pity). So let it have any mnemonic. Patch itself, you cannot remove those '_()' calls, it localizes texts (your changes in libedataserverui/e-name-selector-dialog.c).
i second milan here, better to have duplicated mnemonics than no mnemonics at all.
Created attachment 100140 [details] [review] Revised patch Thanks for letting me know. I wasn't sure what the proper action to take would be, but you've cleared that up. I've restored the mnemonics for the Add and Remove buttons, and changed the mnemonic for the Category label to 'g' to avoid clashing with the 'a' mnemonic in the Add buttons. As for the localization issue, I wasn't aware that the '_()' call was what triggered the localization. Thank you for explaining that. One more thing: This bug is technically in evolution-data-server, in case you wish to change the Product assignment.
OK, I changed component to eds. It looks fine. We have there a clash with 'c' in 'CC:' and 'Close', but it's same issue as with Add/Remove, so I think we can omit it. I will commit to trunk. Thanks for your help.
Committed to trunk. Committed revision 8266. Also, the mnemonic for 'g' is not visible in UI, but who cares :)