After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322846 - at-spi fails to configure on Fedora Core 4
at-spi fails to configure on Fedora Core 4
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: build
unspecified
Other Linux
: Immediate blocker
: ---
Assigned To: bill.haneman
bill.haneman
Depends on:
Blocks:
 
 
Reported: 2005-11-30 15:38 UTC by sobhi
Modified: 2006-02-20 15:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
config.log generated for at-spi (55.42 KB, text/plain)
2005-11-30 20:12 UTC, sobhi
  Details
short term solution to get at-spi to build (1015 bytes, patch)
2006-01-20 02:12 UTC, Brent Smith (smitten)
none Details | Review
alternate patch which removes intltool dependency and translation (2.36 KB, patch)
2006-01-20 12:26 UTC, bill.haneman
none Details | Review
patch which attempts to reinstate i18n for at-spi, but doesn't distcheck (4.39 KB, patch)
2006-02-17 16:41 UTC, bill.haneman
none Details | Review
Update to billh's patch to fix dist issues (4.55 KB, patch)
2006-02-17 18:46 UTC, Rodney Dawes
committed Details | Review

Description sobhi 2005-11-30 15:38:19 UTC
Distribution/Version: Fedora Core 4

Fresh build of Gnome 2.12.x using JHBUILD on Fedora Core 4. The following error
is  encountered:

config.status: executing depfiles commands
config.status: executing po/stamp-it commands
config.status: error: po/Makefile is not ready.
*** Configuring at-spi *** [1/1]
./autogen.sh --prefix /opt/lap/g2bin/2.12  --disable-static --disable-gtk-doc
*** error during stage configure of at-spi: could not configure module *** [1/1]
*** the following modules were not built *** [1/1]
at-spi
Comment 1 bill.haneman 2005-11-30 15:44:00 UTC
No idea what this is about.  Looks like something related to the i18n, could
someone in i18n look at this please?

Also, please attach config.log, it will help.
Comment 2 sobhi 2005-11-30 20:12:48 UTC
Created attachment 55446 [details]
config.log generated for at-spi

config.log file that was requested
Comment 3 sobhi 2005-12-05 19:02:38 UTC
any progress here? do you need any additional log files?
Comment 4 sobhi 2005-12-06 01:14:56 UTC
interesting see comments #9 (problem) and #12 (solution?) on the following 
http://bugzilla.gnome.org/show_bug.cgi?id=323282
Comment 5 sobhi 2005-12-09 16:03:56 UTC
has anyone been successful in resolving this blocker?
can provide additional info to help?
Comment 6 bill.haneman 2005-12-09 16:11:41 UTC
Weird since at-spi requires automake 1.7.
Comment 7 Elijah Newren 2006-01-06 00:34:56 UTC
I see the same issue.  Doing a 'cp -a po/Makefile.in.in po/Makefile.in' and adding po/Makefile to the list of files in the AC_OUTPUT directive of configure.in seems to fix things.  I'm no auto* expert so this may not be correct (I was just trying to figure out how to do what dobey suggested in bug 323282 comment 12), but it does seem to work.
Comment 8 Björn Lindqvist 2006-01-07 09:20:03 UTC
It worked when I uncommented the GLIB_GNU_GETTEXT and ALL_LINGUAS lines and added po/Makefile.in to AC_OUTPUT. In GLIB_WITH_NLS in aclocal.m4 there is a line:

sed -e "/POTFILES =/r po/POTFILES" po/Makefile.in > po/Makefile

Which isn't run without GLIB_GNU_GETTEXT so no Makefile is generated. Why are the lines commented out?

Comment 9 alessandro ferrucci 2006-01-14 02:04:24 UTC
yes, I'm getting the same problem, there is no Makefile.in generated for po/ directory.
Comment 10 Elijah Newren 2006-01-14 02:13:21 UTC
Building bug -> immediate.
Comment 11 Brent Smith (smitten) 2006-01-20 02:11:05 UTC
The message is coming from intltool.

Take a look at intltool.m4, line 182.

It seems that intltool requires that there be a po/Makefile

But since we (Bill) does not want to translate at-spi, he removed the ALL_LINGUAS from the configure.in - I think intltool then does not convert the po/Makefile.in.in to po/Makefile.in

But removing the AC_PROG_INTLTOOL from the configure.in creates other problems, as intltool is required for the registryd/Makefile.am and registryd//Accessibility_Registry.server.in.in

I think the short term solution is to re-enable the ALL_LINGUAS for like one language (so that intltool creates po/Makefile.in from po/Makefile.in.in) and then adding po/Makefile.in to the AC_OUTPUT command

The long term solution is to decide whether or not at-spi should be translated (looks like it has flipped a couple times in the ChangeLog) and modify the release accordingly.

I'm not auto* expert either.  Perhaps an intltool developer could be of more help here. 

I'm attaching a patch that fixes this short term so other people get through jhbuild.
Comment 12 Brent Smith (smitten) 2006-01-20 02:12:04 UTC
Created attachment 57684 [details] [review]
short term solution to get at-spi to build
Comment 13 bill.haneman 2006-01-20 12:06:24 UTC
translating the at-spi registry server is mostly harmless, I suppose, but it introduces the whole intltool framework for the sake of two strings, neither of which are interesting to users.

Perhaps the right fix is to remove intltool, change the .server.in make rule to omit intltool/translation stage, etc.

(The intltool stuff got (accidentally) put back by Kjartan in a previous patch, I believe).
Comment 14 bill.haneman 2006-01-20 12:26:02 UTC
Created attachment 57721 [details] [review]
alternate patch which removes intltool dependency and translation

This attachment avoids the issue by making the .server file from the .server.in.in file without translation, thus there is no need for intltool or the po directory at all.
Comment 15 bill.haneman 2006-01-20 17:49:07 UTC
I applied the intltool-removing patch to cvs.
Comment 16 bill.haneman 2006-02-17 15:32:17 UTC
Because of other issues with the above approch (see bug 331484), and the fact that localizing the .server file is harmless, I'm reinstating localization/translation of AT-SPI.  Again...

Hope this still works OK for Fedora Core 4, I did add po/Makefile.in to AC_OUTPUT as suggested by Brent.
Comment 17 bill.haneman 2006-02-17 16:31:15 UTC
Well, I can't get the above change to work.  autogen and make are fine, but make distcheck fails.  Seems to be because po/Makefile.in.in, which gets created on autogen, doesn't get created by configure, or included in the dist.  Any ideas?
Comment 18 bill.haneman 2006-02-17 16:41:54 UTC
Created attachment 59586 [details] [review]
patch which attempts to reinstate i18n for at-spi, but doesn't distcheck

make and autogen work fine with this patch, but make distcheck fails, so I expect applying the patch would cause tarballs to fail to build properly again.  What's wrong?
Comment 19 Rodney Dawes 2006-02-17 18:46:58 UTC
Created attachment 59601 [details] [review]
Update to billh's patch to fix dist issues

This patch fixes the minor issues in Bill's patch that cause distcheck to fail. In Makefile.am, po also needed to be added to SUBDIRS, and in configure.in, a couple of extra bits need to be defined for the gettext stuff. GETTEXT_PACKAGE is an especially important item to define.
Comment 20 bill.haneman 2006-02-20 15:06:08 UTC
Thanks Rodney - I've applied your patch and am closing out the bug again.